This repository was archived by the owner on Apr 7, 2026. It is now read-only.
refactor: Removing duplicate calls to set expiration time#1996
Merged
rajatbhatta merged 1 commit intogoogleapis:mainfrom Sep 6, 2022
Merged
refactor: Removing duplicate calls to set expiration time#1996rajatbhatta merged 1 commit intogoogleapis:mainfrom
rajatbhatta merged 1 commit intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
size: xs
gauravpurohit06
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
rajatbhatta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
rajatbhatta
approved these changes
Sep 6, 2022
Contributor
|
Thank you for the contribution @MedhaCS1010 . Just curious, how did you come across this duplicate call? |
Contributor
Author
|
Hey @ansh0l , So basically I was exploring Integration tests to understand the flow and how the library is being used and at that time I found there was this duplicate call to set max_expire_time for backups which I modified .. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing redundant calls to set the expiration time of backup. Expiration Time is already set in line 283.