This repository was archived by the owner on Apr 7, 2026. It is now read-only.
test: Creating dummy spanner instance for ITInstanceAdminTest#1977
Merged
gauravpurohit06 merged 7 commits intogoogleapis:mainfrom Aug 22, 2022
Merged
test: Creating dummy spanner instance for ITInstanceAdminTest#1977gauravpurohit06 merged 7 commits intogoogleapis:mainfrom
gauravpurohit06 merged 7 commits intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
size: s
gauravpurohit06
added
the
do not merge
gauravpurohit06
removed
the
do not merge
gauravpurohit06
changed the title
rajatbhatta
reviewed
Aug 18, 2022
rajatbhatta
suggested changes
Aug 18, 2022
Contributor
rajatbhatta
left a comment
rajatbhatta
left a comment
There was a problem hiding this comment.
Overall it looks good to me, except a comment. PTAL.
olavloite
reviewed
Aug 18, 2022
olavloite
approved these changes
Aug 19, 2022
Collaborator
olavloite
left a comment
olavloite
left a comment
There was a problem hiding this comment.
LGTM, with a suggestion regarding the naming of the createNewInstance / alwaysCreateNewInstance property.
rajatbhatta
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
gauravpurohit06
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
gauravpurohit06
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1626