Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

test: test embedded comment in comment#1919

Merged
alicejli merged 1 commit intomainfrom
test-embedded-comment
Jul 13, 2022
Merged

test: test embedded comment in comment#1919
alicejli merged 1 commit intomainfrom
test-embedded-comment

Conversation

@olavloite
Copy link
Copy Markdown
Collaborator

@olavloite olavloite commented Jun 22, 2022

Tests that block comments embedded in other block comments are parsed correctly by the PostgreSQL parser.

@olavloite olavloite requested a review from a team June 22, 2022 05:34
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Jun 22, 2022
@olavloite olavloite requested a review from thiagotnunes June 22, 2022 05:45
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2022
@olavloite olavloite added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2022
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2022
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Jun 22, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 22, 2022
@ansh0l
Copy link
Copy Markdown
Contributor

ansh0l commented Jul 4, 2022

@olavloite : I think since the PR for this change is merged, should we close this PR?

@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2022
@olavloite
Copy link
Copy Markdown
Collaborator Author

olavloite commented Jul 4, 2022 •
edited
Loading

I think since the PR for this change is merged, should we close this PR?

No, this did not require a change, but I think we should merge it, as it adds a test for a scenario that was not covered (but did work as expected). (The failed integration test was unrelated)

@alicejli alicejli merged commit 1822a13 into main Jul 13, 2022
@alicejli alicejli deleted the test-embedded-comment branch July 13, 2022 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@thiagotnunes thiagotnunes thiagotnunes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@olavloite @ansh0l @thiagotnunes @yoshi-kokoro @alicejli