This repository was archived by the owner on Apr 7, 2026. It is now read-only.
feat: Track PG Adapter usage from user-agent headers#1711
Merged
olavloite merged 6 commits intogoogleapis:mainfrom Feb 28, 2022
Merged
feat: Track PG Adapter usage from user-agent headers#1711olavloite merged 6 commits intogoogleapis:mainfrom
olavloite merged 6 commits intogoogleapis:mainfrom
Conversation
…oken, so that when PG Adapter connects via client library by passing the string "pg-adapter" in the user-agent header, it doesn't get discarded.
product-auto-label
Bot
added
the
api: spanner
gauravsnj
changed the title
olavloite
reviewed
Feb 23, 2022
| .setCredentials(NoCredentials.getInstance()) | ||
| .setClientLibToken(pgAdapterToken) | ||
| .build(); | ||
| assertThat(options.getClientLibToken()).isEqualTo(pgAdapterToken); |
Collaborator
There was a problem hiding this comment.
nit: we prefer the use of assertEquals(expected, actual) (add import static org.junit.Assert.assertEquals at the top of the file to import it)
I know that it is not consistent with the other tests here, but the general rule of thumb is to use this method for new code, even when it is different from the surrounding code.
Contributor
Author
There was a problem hiding this comment.
Thanks @olavloite for mentioning this. I've changed it and will remember this in future
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
approved these changes
Feb 24, 2022
Collaborator
|
@ansh0l Do you know why the OwlBot check seems to be hanging? Is that because the PR has been created from a fork instead of a branch directly in the repository? And if so, is that something you can override for this PR? |
Contributor
|
@olavloite it does not run by default from forks, we just need to add the label |
thiagotnunes
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
gauravsnj
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
gauravsnj
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the string "pg-adapter" in the list of allowed client library token, so that when PG Adapter connects via client library by passing the string "pg-adapter" in the user-agent header, it doesn't get discarded. Also, added the one test case to cover the same.
Fixes b/213946108