Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

fix: use information_schema instead of pg_catalog for dialect detection#1708

Merged
olavloite merged 1 commit intomainfrom
use-information-schema-for-dialect-detection
Feb 21, 2022
Merged

fix: use information_schema instead of pg_catalog for dialect detection#1708
olavloite merged 1 commit intomainfrom
use-information-schema-for-dialect-detection

Conversation

@olavloite
Copy link
Copy Markdown
Collaborator

Automatic dialect detection should not rely on pg_catalog being present in the information_schema to determine that it is a PostgreSQL database. Instead, the presence of an upper/lower case INFORMATION_SCHEMA / information_schema should be used to determine which of the two dialects is being used.

@olavloite olavloite requested review from a team, ansh0l and thiagotnunes February 21, 2022 17:56
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/java-spanner API. label Feb 21, 2022
Copy link
Copy Markdown
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olavloite olavloite merged commit 91e157a into main Feb 21, 2022
@olavloite olavloite deleted the use-information-schema-for-dialect-detection branch February 21, 2022 18:21
gcf-owl-bot Bot added a commit that referenced this pull request Nov 10, 2022
Source-Link: googleapis/synthtool@fbc8bfe
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:e76136cc48f90aa19ba29cdfbd4002111467e44a1c9d905867d98dafafbd03bb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants