Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

fix: annotating some fields as REQUIRED#1695

Merged
ansh0l merged 2 commits intomainfrom
owl-bot-copy
Feb 25, 2022
Merged

fix: annotating some fields as REQUIRED#1695
ansh0l merged 2 commits intomainfrom
owl-bot-copy

Conversation

@gcf-owl-bot
Copy link
Copy Markdown
Contributor

@gcf-owl-bot gcf-owl-bot Bot commented Feb 16, 2022

  • Regenerate this pull request now.

These fields were actually always required by the backend, so annotation just documents status quo. I believe this change will not require major version bump for any language.

PiperOrigin-RevId: 429093810

Source-Link: googleapis/googleapis@dc04c1c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/0e23469bea2f397f2b783c5a25e64452f86be6bc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGUyMzQ2OWJlYTJmMzk3ZjJiNzgzYzVhMjVlNjQ0NTJmODZiZTZiYyJ9

@gcf-owl-bot
fix!: annotating some fields as REQUIRED
563a465 
These fields were actually always required by the backend, so annotation just documents status quo. I believe this change will not require major version bump for any language.

PiperOrigin-RevId: 429093810

Source-Link: googleapis/googleapis@dc04c1c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/0e23469bea2f397f2b783c5a25e64452f86be6bc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGUyMzQ2OWJlYTJmMzk3ZjJiNzgzYzVhMjVlNjQ0NTJmODZiZTZiYyJ9
@gcf-owl-bot gcf-owl-bot Bot requested review from a team February 16, 2022 20:49
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/java-spanner API. label Feb 16, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2022
@thiagotnunes thiagotnunes added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 17, 2022
@thiagotnunes
Copy link
Copy Markdown
Contributor

thiagotnunes commented Feb 17, 2022

Is this a breaking change? If so, it would require us to do a major release, which is not ideal

@ansh0l could you follow up?

@ansh0l
Copy link
Copy Markdown
Contributor

ansh0l commented Feb 17, 2022

Sure @thiagotnunes, will followup

@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Feb 17, 2022
suztomo
suztomo previously approved these changes Feb 17, 2022
View reviewed changes
@suztomo suztomo dismissed their stale review February 17, 2022 19:02

mistake

@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Feb 17, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 17, 2022
@suztomo
Copy link
Copy Markdown
Member

suztomo commented Feb 18, 2022

@ansh0l cl/429093810 has description about the change and it says the author doesn't expect breaking change in customers' code. If this is the case, there's no need to bump the major version.

The automation bot reads "!" in "feat!" for breaking changes. If this is not a breaking change, then remove "!" from the PR title. When merging, ensure the squashed commit to the main branch doesn't have "!" either.

ansh0l
ansh0l approved these changes Feb 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will go with suggestion by @suztomo for minor revision bump

@ansh0l
Copy link
Copy Markdown
Contributor

ansh0l commented Feb 24, 2022

Will be parking this PR for some more time before other major PRs are shipped for java and jdbc.

@Neenu1995 Neenu1995 changed the title fix!: annotating some fields as REQUIRED fix: annotating some fields as REQUIRED Feb 24, 2022
@thiagotnunes
Copy link
Copy Markdown
Contributor

thiagotnunes commented Feb 24, 2022

@ansh0l afaik we can merge now, because we removed the !, so it won't be a breaking change. Or do we need to wait for anything else?

@ansh0l
Copy link
Copy Markdown
Contributor

ansh0l commented Feb 25, 2022

@thiagotnunes I think we are good. I was busy with Spangres merges yesterday, so kept it waiting for another day.

@ansh0l ansh0l removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 25, 2022
@ansh0l ansh0l merged commit 8b90b6c into main Feb 25, 2022
@ansh0l ansh0l deleted the owl-bot-copy branch February 25, 2022 02:26
@release-please release-please Bot mentioned this pull request Feb 25, 2022
Merged
gcf-owl-bot Bot added a commit that referenced this pull request Nov 7, 2022
@gcf-owl-bot
chore(java): update dependencies in java requirements file (#1695)
339bbfb 
* chore(java): update gcp-releasetool and cryptography in java requirements file
Source-Link: googleapis/synthtool@74d0956
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
@gcf-owl-bot
chore(java): update dependencies in java requirements file (googleapi…
346f543 
…s#1695) (googleapis#1043)

* chore(java): update gcp-releasetool and cryptography in java requirements file
Source-Link: https://togithub.com/googleapis/synthtool/commit/74d0956884c1bb9dc901b52de35ca2bca025a74e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ansh0l ansh0l ansh0l approved these changes

@suztomo suztomo suztomo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. owl-bot-copy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thiagotnunes @ansh0l @suztomo @yoshi-kokoro