Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

Add missing "return" and improve comment in TransactionRunnerImpl #830

Closed
#844
Closed
Add missing "return" and improve comment in TransactionRunnerImpl#830
#844
Assignees
olavloite
Labels
api: spannerIssues related to the googleapis/java-spanner API.type: cleanupAn internal cleanup or hygiene concern.
@dzhang-bap

Description

@dzhang-bap
dzhang-bap
opened on Jan 29, 2021

The code at

java-spanner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/TransactionRunnerImpl.java

Line 466 in 8024980

TransactionSelector.newBuilder()
is missing a "return". Otherwise it creates a temporary TransactionSelector variable without using it. The comment above the line should also be improved by pointing out that tx.get(), upon success, sets transactionId because tx is a future for transactionId.

Metadata

Metadata

Assignees

Labels

api: spannerIssues related to the googleapis/java-spanner API.type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions