fix: extract strings to constants

olavloite · olavloite · commit 441dcf251de8 · 2020-11-27T08:45:08.000+01:00
diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AdminRequestsPerMinuteExceededException.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AdminRequestsPerMinuteExceededException.java
@@ -25,6 +25,9 @@
 public class AdminRequestsPerMinuteExceededException extends SpannerException {
   private static final long serialVersionUID = -6395746612598975751L;
 
+  static final String ADMIN_REQUESTS_LIMIT_KEY = "quota_limit";
+  static final String ADMIN_REQUESTS_LIMIT_VALUE = "AdminMethodQuotaPerMinutePerProject";
+
   /** Private constructor. Use {@link SpannerExceptionFactory} to create instances. */
   AdminRequestsPerMinuteExceededException(
       DoNotConstructDirectly token, @Nullable String message, @Nullable Throwable cause) {
diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerExceptionFactory.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerExceptionFactory.java
@@ -236,9 +236,11 @@ static SpannerException newSpannerExceptionPreformatted(
       case RESOURCE_EXHAUSTED:
         ErrorInfo info = extractErrorInfo(cause);
         if (info != null
-            && info.getMetadataMap().containsKey("quota_limit")
-            && "AdminMethodQuotaPerMinutePerProject"
-                .equals(info.getMetadataMap().get("quota_limit"))) {
+            && info.getMetadataMap()
+                .containsKey(AdminRequestsPerMinuteExceededException.ADMIN_REQUESTS_LIMIT_KEY)
+            && AdminRequestsPerMinuteExceededException.ADMIN_REQUESTS_LIMIT_VALUE.equals(
+                info.getMetadataMap()
+                    .get(AdminRequestsPerMinuteExceededException.ADMIN_REQUESTS_LIMIT_KEY))) {
           return new AdminRequestsPerMinuteExceededException(token, message, cause);
         }
       case NOT_FOUND:
