Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

Commit 402cfa1

Browse files
olavloiteolavloite
authored
fix: ignore added interface methods for generated code (#101)
Adds generic ignore rules for added methods to interfaces in the generated code. Fixes #99
1 parent 37b7c88 commit 402cfa1

3 files changed

Lines changed: 16 additions & 39 deletions

File tree

‎proto-google-cloud-spanner-admin-database-v1/clirr-ignored-differences.xml‎

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,10 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
33
<differences>
4+
<!-- Ignore all new methods in interfaces in the generated code. -->
45
<difference>
56
<differenceType>7012</differenceType>
6-
<className>com/google/spanner/admin/database/v1/DatabaseOrBuilder</className>
7-
<method>* getCreateTime()</method>
8-
</difference>
9-
<difference>
10-
<differenceType>7012</differenceType>
11-
<className>com/google/spanner/admin/database/v1/DatabaseOrBuilder</className>
12-
<method>* getCreateTimeOrBuilder()</method>
13-
</difference>
14-
<difference>
15-
<differenceType>7012</differenceType>
16-
<className>com/google/spanner/admin/database/v1/DatabaseOrBuilder</className>
17-
<method>* getRestoreInfo()</method>
18-
</difference>
19-
<difference>
20-
<differenceType>7012</differenceType>
21-
<className>com/google/spanner/admin/database/v1/DatabaseOrBuilder</className>
22-
<method>* getRestoreInfoOrBuilder()</method>
23-
</difference>
24-
<difference>
25-
<differenceType>7012</differenceType>
26-
<className>com/google/spanner/admin/database/v1/DatabaseOrBuilder</className>
27-
<method>* hasCreateTime()</method>
28-
</difference>
29-
<difference>
30-
<differenceType>7012</differenceType>
31-
<className>com/google/spanner/admin/database/v1/DatabaseOrBuilder</className>
32-
<method>* hasRestoreInfo()</method>
7+
<className>com/google/spanner/admin/database/v1/*</className>
8+
<method>*</method>
339
</difference>
3410
</differences>

‎proto-google-cloud-spanner-admin-instance-v1/clirr-ignored-differences.xml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
3+
<differences>
4+
<!-- Ignore all new methods in interfaces in the generated code. -->
5+
<difference>
6+
<differenceType>7012</differenceType>
7+
<className>com/google/spanner/admin/instance/v1/*</className>
8+
<method>*</method>
9+
</difference>
10+
</differences>

‎proto-google-cloud-spanner-v1/clirr-ignored-differences.xml‎

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,10 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
33
<differences>
4+
<!-- Ignore all new methods in interfaces in the generated code. -->
45
<difference>
56
<differenceType>7012</differenceType>
6-
<className>com/google/spanner/v1/ExecuteSqlRequestOrBuilder</className>
7-
<method>* getQueryOptions()</method>
8-
</difference>
9-
<difference>
10-
<differenceType>7012</differenceType>
11-
<className>com/google/spanner/v1/ExecuteSqlRequestOrBuilder</className>
12-
<method>* getQueryOptionsOrBuilder()</method>
13-
</difference>
14-
<difference>
15-
<differenceType>7012</differenceType>
16-
<className>com/google/spanner/v1/ExecuteSqlRequestOrBuilder</className>
17-
<method>* hasQueryOptions()</method>
7+
<className>com/google/spanner/v1/*</className>
8+
<method>*</method>
189
</difference>
1910
</differences>

0 commit comments

Comments
 (0)