Skip to content

chore: updating contribution guideline#757

Merged
suztomo merged 4 commits intomainfrom
contributing
Mar 7, 2024
Merged

chore: updating contribution guideline#757
suztomo merged 4 commits intomainfrom
contributing

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Feb 20, 2024

b/323263307

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@suztomo suztomo requested a review from a team February 20, 2024 21:13
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • CONTRIBUTING.md

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. size: u Pull request is empty. and removed size: xs Pull request size is extra small. labels Feb 20, 2024
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. and removed size: u Pull request is empty. labels Feb 22, 2024
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Feb 28, 2024
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 29, 2024
@suztomo suztomo merged commit e16c3c2 into main Mar 7, 2024
@suztomo suztomo deleted the contributing branch March 7, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants