Skip to content

fix: move release configs to native-image-shared-config #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpeddada1 merged 4 commits into from
Dec 7, 2023
Merged

fix: move release configs to native-image-shared-config #725

mpeddada1 merged 4 commits into from
Dec 7, 2023

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Dec 6, 2023 •
edited
Loading

To address release job failure:

[ERROR] No plugin found for prefix 'nexus-staging' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (/root/.m2/repository), central ([https://repo.maven.apache.org/maven2](https://www.google.com/url?q=https://repo.maven.apache.org/maven2&sa=D))] -> [Help 1]

The nexus-staging-maven-plugin was only declared in java-shared-config initially and not in native-image-shared-config (the parent).

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 6, 2023
@mpeddada1 mpeddada1 marked this pull request as ready for review December 6, 2023 23:12
@mpeddada1 mpeddada1 requested a review from a team as a code owner December 6, 2023 23:12
@mpeddada1 mpeddada1 changed the title fix: introduce release profile in native-image-shared-config fix: move release configs to native-image-shared-config Dec 6, 2023
@mpeddada1 mpeddada1 requested a review from suztomo December 6, 2023 23:13
suztomo
suztomo approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits with indent. Let's get error messages.

@mpeddada1 mpeddada1 mentioned this pull request Dec 7, 2023
Closed
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2023
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Dec 7, 2023

Confirmed that the staging job passed:

[INFO] --- maven-deploy-plugin:3.1.1:deploy (default-deploy) @ google-cloud-shared-config-parent ---
[INFO] Skipping artifact deployment
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Native Image Shared Config 1.7.0 ................... SUCCESS [02:22 min]
[INFO] Google Cloud Shared Config 1.7.0 ................... SUCCESS [02:25 min]
[INFO] google-cloud-shared-config-parent 0.1.0-SNAPSHOT ... SUCCESS [ 22.563 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  05:11 min
[INFO] Finished at: 2023-12-07T16:55:00Z
[INFO] ------------------------------------------------------------------------
Finished uploading the staging repository
AUTORELEASE_PR is not specified. Not promoting the release.

@mpeddada1 mpeddada1 merged commit 58ffb4e into main Dec 7, 2023
@mpeddada1 mpeddada1 deleted the restore-release-configs branch December 7, 2023 17:08
@release-please release-please bot mentioned this pull request Dec 7, 2023
Merged
This was referenced Dec 14, 2023
Closed
Closed
Closed
@release-please release-please bot mentioned this pull request Dec 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suztomo suztomo suztomo approved these changes

Assignees

No one assigned

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpeddada1 @suztomo @yoshi-kokoro