Skip to content

chore: add downstream check for native image tests in cloud build #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpeddada1 merged 9 commits into from
Dec 5, 2023
Merged

chore: add downstream check for native image tests in cloud build #715

mpeddada1 merged 9 commits into from
Dec 5, 2023

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Nov 29, 2023 •
edited
Loading

Only Showcase tests are included in this PR.

@mpeddada1 mpeddada1 requested a review from a team as a code owner November 29, 2023 15:43
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 29, 2023
@burkedavison
Copy link
Member

burkedavison commented Nov 29, 2023

Looks promising! Please let me know when to take a look after the build issues are resolved.

@mpeddada1 mpeddada1 changed the title chore: add dowsntream check for native image tests in cloud build chore: add downstream check for native image tests in cloud build Nov 30, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 30, 2023
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Nov 30, 2023

Will do!
Showcase tests are passing but now running into the following monorepo tests:

Step #2: ERROR: (gcloud.config.set) value for field [projectId] in collection [cloudresourcemanager.projects] is required but was not provided
Finished Step #2
ERROR
ERROR: build step 2 "gcr.io/cloud-devrel-public-resources/graalvm_a:1.6.1" failed: step exited with non-zero status: 1

@mpeddada1 mpeddada1 merged commit 3382cee into main Dec 5, 2023
@mpeddada1 mpeddada1 deleted the add-downstream-cloudbuild branch December 5, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@burkedavison burkedavison burkedavison approved these changes

Assignees

No one assigned

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpeddada1 @burkedavison