Skip to content

Conversation

@mpeddada1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mpeddada1 mpeddada1 requested a review from a team as a code owner November 28, 2023 23:34
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 28, 2023
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/sync-repo-settings.yaml

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Nov 29, 2023
@mpeddada1 mpeddada1 closed this Nov 30, 2023
@mpeddada1 mpeddada1 reopened this Nov 30, 2023
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Nov 30, 2023

Kokoro - Test: Java 17 GraalVM Native Image is still showing up as required check despite being removed from .github/sync-repo-settings.yaml. Edited branch protection rules.

@mpeddada1 mpeddada1 merged commit 328d0a4 into main Nov 30, 2023
@mpeddada1 mpeddada1 deleted the remove-native-kokoro branch November 30, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants