Skip to content

feat: separate native-image-shared-config into its own module #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpeddada1 merged 13 commits into from
Nov 30, 2023
Merged

feat: separate native-image-shared-config into its own module #712

mpeddada1 merged 13 commits into from
Nov 30, 2023

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Nov 16, 2023 •
edited by suztomo
Loading

  • This PR separates out the native image configurations into their own artifact called native-image-shared-config. A pom.xml file focused on native image is easier to maintain.
  • The native-image-shared-config artifact is brought in as a parent of java-shared-config
  • Testing locally with google-http-java-client by adding the following and running mvn test -Pnative -Pnative-deps -Dtest=*Test:
 <parent>
    <groupId>com.google.cloud</groupId>
    <artifactId>native-image-shared-config</artifactId>
    <version>1.6.2-SNAPSHOT</version>
  </parent>

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Nov 16, 2023
@mpeddada1 mpeddada1 marked this pull request as ready for review November 16, 2023 23:14
@mpeddada1 mpeddada1 requested a review from a team as a code owner November 16, 2023 23:14
@mpeddada1 mpeddada1 changed the title feat: separate native-image-shared-config into it's own module feat: separate native-image-shared-config into its own module Nov 16, 2023
meltsufin
meltsufin reviewed Nov 18, 2023
View reviewed changes
java-shared-config/pom.xml Outdated
Comment on lines 15 to 58
<developers>
<developer>
<id>chingor13</id>
<name>Jeff Ching</name>
<email>[email protected]</email>
<organization>Google</organization>
<roles>
<role>Developer</role>
</roles>
</developer>
</developers>
<organization>
<name>Google LLC</name>
</organization>
<scm>
<connection>scm:git:[email protected]:googleapis/java-shared-config.git</connection>
<developerConnection>scm:git:[email protected]:googleapis/java-shared-config.git
</developerConnection>
<url>https://github.com/googleapis/java-shared-config</url>
<tag>HEAD</tag>
</scm>

<issueManagement>
<url>https://github.com/googleapis/java-shared-config/issues</url>
<system>GitHub Issues</system>
</issueManagement>

<distributionManagement>
<snapshotRepository>
<id>sonatype-nexus-snapshots</id>
<url>https://google.oss.sonatype.org/content/repositories/snapshots</url>
</snapshotRepository>
<repository>
<id>sonatype-nexus-staging</id>
<url>https://google.oss.sonatype.org/service/local/staging/deploy/maven2/</url>
</repository>
</distributionManagement>

<licenses>
<license>
<name>Apache-2.0</name>
<url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
</license>
</licenses>
Copy link
Member

@meltsufin meltsufin Nov 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to move this section to the new root parent native-image-shared-config, and it doesn't need to be duplicated here as it will be inherited.

Copy link
Contributor Author

@mpeddada1 mpeddada1 Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, done. Moved this content from java-shared-config/pom.xml to native-image-shared-config/pom.xml and removed the duplicated content.

@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2023
@suztomo
Copy link
Member

suztomo commented Nov 28, 2023

Once you merge this "feat" pull request, check Release Please pull request has correct updates for the versions.

@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2023
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Nov 28, 2023

Thank you @suztomo! Also the stage job ran successfully with this PR:

INFO] --- maven-deploy-plugin:3.1.1:deploy (default-deploy) @ google-cloud-shared-config-parent ---
[INFO] Skipping artifact deployment
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Native Image Shared Config 1.6.2-SNAPSHOT .......... SUCCESS [01:41 min]
[INFO] Google Cloud Shared Config 1.6.2-SNAPSHOT .......... SUCCESS [02:36 min]
[INFO] google-cloud-shared-config-parent 0.1.0-SNAPSHOT ... SUCCESS [  0.910 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  05:33 min
[INFO] Finished at: 2023-11-28T16:01:50Z
[INFO] ------------------------------------------------------------------------
Finished uploading the staging repository

@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Nov 28, 2023

The failure of job labelled kokoro is due to a failure in the publish_javadoc job which shows:

cp: cannot create regular file 'target/docfx-yml/history.md': No such file or directory

It appears that this job has experienced this issue since the last couple of releases:
Screenshot 2023-11-28 at 6 42 54 PM

@burkedavison
Copy link
Member

burkedavison commented Nov 29, 2023

I'm surprised that publish_javadoc11.sh is involved with this repo since we aren't publishing documentation anywhere. It might be that this job is unnecessary.

@alicejli
Copy link
Contributor

alicejli commented Nov 29, 2023

I'm surprised that publish_javadoc11.sh is involved with this repo since we aren't publishing documentation anywhere. It might be that this job is unnecessary.

Piping in here - pretty sure all the Kokoro release jobs in this repo are obsolete as they were migrated to g3. See cl/533291527

@mpeddada1 mpeddada1 merged commit 567fecb into main Nov 30, 2023
@mpeddada1 mpeddada1 deleted the native-artifact branch November 30, 2023 00:34
@release-please release-please bot mentioned this pull request Nov 30, 2023
Merged
@mpeddada1 mpeddada1 mentioned this pull request Jan 26, 2024
Merged
@release-please release-please bot mentioned this pull request Dec 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meltsufin meltsufin meltsufin left review comments

@suztomo suztomo suztomo approved these changes

@burkedavison burkedavison burkedavison approved these changes

Assignees

No one assigned

Labels

size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mpeddada1 @suztomo @burkedavison @alicejli @meltsufin @yoshi-kokoro