Skip to content

chore: add downstream testing for showcase tests #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpeddada1 merged 2 commits into from
Nov 15, 2023
Merged

chore: add downstream testing for showcase tests #709

mpeddada1 merged 2 commits into from
Nov 15, 2023

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Nov 15, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mpeddada1 mpeddada1 requested a review from a team as a code owner November 15, 2023 21:26
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 15, 2023
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Nov 15, 2023

Confirmation that showcase tests are running:

Test run finished after 117825 ms
[        26 containers found      ]
[         0 containers skipped    ]
[        26 containers started    ]
[         0 containers aborted    ]
[        26 containers successful ]
[         0 containers failed     ]
[       278 tests found           ]
[         1 tests skipped         ]
[       277 tests started         ]
[         0 tests aborted         ]
[       277 tests successful      ]
[         0 tests failed          ]

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for GAPIC Showcase Client Core Parent 0.0.1-SNAPSHOT:
[INFO]
[INFO] GAPIC Showcase Client Core Parent .................. SUCCESS [  1.917 s]
[INFO] proto-gapic-showcase-v1beta1 ....................... SUCCESS [  8.415 s]
[INFO] grpc-gapic-showcase-v1beta1 ........................ SUCCESS [  1.113 s]
[INFO] GAPIC Showcase Client .............................. SUCCESS [09:37 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  09:54 min
[INFO] Finished at: 2023-11-15T21:41:30Z
[INFO] ------------------------------------------------------------------------

@mpeddada1 mpeddada1 merged commit 6e1c09c into main Nov 15, 2023
@mpeddada1 mpeddada1 deleted the add-showcase-downstream-check branch November 15, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@burkedavison burkedavison burkedavison approved these changes

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mpeddada1 @burkedavison