Skip to content

chore: Renaming auto-value-annotation.version to auto-value.version#674

Merged
ddixit14 merged 3 commits intomainfrom
auto-value-deps
Oct 5, 2023
Merged

chore: Renaming auto-value-annotation.version to auto-value.version#674
ddixit14 merged 3 commits intomainfrom
auto-value-deps

Conversation

@ddixit14
Copy link
Copy Markdown
Contributor

@ddixit14 ddixit14 commented Oct 4, 2023

No description provided.

@ddixit14 ddixit14 requested a review from a team October 4, 2023 23:52
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Oct 4, 2023
@ddixit14
Copy link
Copy Markdown
Contributor Author

ddixit14 commented Oct 5, 2023

  1. downstream / dependencies (11, java-pubsub) is failing with error:
Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project google-cloud-pubsub: Resolution of annotationProcessorPath dependencies failed: version can neither be null, empty nor blank.
  1. downstream / javadoc-with-doclet (java-bigtable) is failing with error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.6.0:aggregate (default-cli) on project google-cloud-bigtable-parent: Execution default-cli of goal org.apache.maven.plugins:maven-javadoc-plugin:3.6.0:aggregate failed: If a non-null excludes list is given, all elements must be non-null -> [Help 1]

@suztomo
Copy link
Copy Markdown
Member

suztomo commented Oct 5, 2023

The pubsub one is concerning. Can you check whether the java-pubsub project references the variable?

downstream / javadoc-with-doclet (java-bigtable) is known to fail for now.

@blakeli0
Copy link
Copy Markdown
Contributor

blakeli0 commented Oct 5, 2023

The pubsub one is concerning. Can you check whether the java-pubsub project references the variable?

downstream / javadoc-with-doclet (java-bigtable) is known to fail for now.

Looks like they are, we should remove the usage there.

@suztomo
Copy link
Copy Markdown
Member

suztomo commented Oct 5, 2023

Confirming whether the maven-compiler-plugin configuration at java-pubsub is really needed or not googleapis/java-pubsub#1761.

@suztomo
Copy link
Copy Markdown
Member

suztomo commented Oct 5, 2023

I merged googleapis/java-pubsub#1761 in pubsub. I just restarted "downstream / dependencies (11, java-pubsub) " job.

@ddixit14
Copy link
Copy Markdown
Contributor Author

ddixit14 commented Oct 5, 2023

downstream / dependencies (11, java-pubsub) has passed now. Merging the PR.

@ddixit14 ddixit14 merged commit a8ac0f0 into main Oct 5, 2023
@ddixit14 ddixit14 deleted the auto-value-deps branch October 5, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants