Skip to content

build(deps): update dependency org.codehaus.mojo:flatten-maven-plugin to v1.3.0#507

Merged
suztomo merged 3 commits intogoogleapis:mainfrom
renovate-bot:renovate/org.codehaus.mojo-flatten-maven-plugin-1.x
Oct 24, 2022
Merged

build(deps): update dependency org.codehaus.mojo:flatten-maven-plugin to v1.3.0#507
suztomo merged 3 commits intogoogleapis:mainfrom
renovate-bot:renovate/org.codehaus.mojo-flatten-maven-plugin-1.x

Conversation

@renovate-bot
Copy link
Copy Markdown
Contributor

@renovate-bot renovate-bot commented Aug 16, 2022 •
edited by suztomo
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.codehaus.mojo:flatten-maven-plugin (source) 1.2.7 -> 1.3.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

BEGIN_COMMIT_OVERRIDE
deps: update dependency org.codehaus.mojo:flatten-maven-plugin to v1.3.0

This resolves the problem of test-scope dependencies unexpectedly excluded.
END_COMMIT_OVERRIDE

@renovate-bot renovate-bot requested a review from a team August 16, 2022 22:22
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Aug 16, 2022
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 16, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 16, 2022
@alicejli alicejli added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2022
@renovate-bot renovate-bot force-pushed the renovate/org.codehaus.mojo-flatten-maven-plugin-1.x branch from c5ade45 to 49c7f7a Compare August 17, 2022 15:34
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 17, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2022
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Aug 17, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 17, 2022
@alicejli alicejli added the automerge Merge the pull request once unit tests and other checks pass. label Aug 18, 2022
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Aug 18, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 18, 2022
@alicejli alicejli added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2022
@renovate-bot renovate-bot force-pushed the renovate/org.codehaus.mojo-flatten-maven-plugin-1.x branch from 49c7f7a to 0d5ab0e Compare August 19, 2022 18:33
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 19, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2022
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Aug 20, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 20, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2022
@meltsufin meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Oct 17, 2022
@renovate-bot renovate-bot force-pushed the renovate/org.codehaus.mojo-flatten-maven-plugin-1.x branch from 8b88ee2 to c3622da Compare October 18, 2022 01:50
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 18, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
@meltsufin
Copy link
Copy Markdown
Member

meltsufin commented Oct 18, 2022 

****************** DEPENDENCY LIST COMPLETENESS CHECK *******************
~/work/java-shared-config/java-shared-config/java-storage/google-cloud-storage ~/work/java-shared-config/java-shared-config/java-storage
2022-10-18 02:03:06 Generating dependency list using original pom...
OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
2022-10-18 02:03:09 Generating dependency list using flattened pom...
OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0
2022-10-18 02:03:15 Comparing dependency lists...
2022-10-18 02:03:15 Diff found. See below: 
2022-10-18 02:03:15 You can also check .diff.txt file located in google-cloud-storage.
15a16
> [INFO]    com.google.errorprone:error_prone_annotations:jar:2.15.0:compile
~/work/java-shared-config/java-shared-config/java-storage
2022-10-18 02:03:15 Errors found. See log statements above.

@suztomo Do you know if this might be a bug in the new version of the Maven flatten plugin?

@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Oct 18, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 18, 2022
@meltsufin meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Oct 18, 2022
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Oct 18, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 18, 2022
@suztomo
Copy link
Copy Markdown
Member

suztomo commented Oct 19, 2022

@meltsufin It's false positive. #507 (comment)

@suztomo suztomo mentioned this pull request Oct 19, 2022
Closed
@renovate-bot renovate-bot force-pushed the renovate/org.codehaus.mojo-flatten-maven-plugin-1.x branch from c3622da to 1110ba1 Compare October 19, 2022 19:19
@trusted-contributions-gcf trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 19, 2022
@suztomo
Copy link
Copy Markdown
Member

suztomo commented Oct 21, 2022 •
edited
Loading

@meltsufin I wrote the analysis that the validation result is false positive #507 (comment) . The flatten plugin new version is working correctly. The validation logic is wrong.

@meltsufin
Copy link
Copy Markdown
Member

meltsufin commented Oct 21, 2022

@meltsufin I wrote the analysis that the validation result is false positive #507 (comment) . The flatten plugin new version is working correctly. The validation logic is wrong.

Can you create an issue for this? Would you be able to provide a fix so that we can upgrade the plugin?

@suztomo
Copy link
Copy Markdown
Member

suztomo commented Oct 21, 2022 •
edited
Loading

Issue #525

The fix in the dependencies.sh (templated in OwlBot post processor): https://github.com/googleapis/synthtool/pull/1663/files

@suztomo
Copy link
Copy Markdown
Member

suztomo commented Oct 24, 2022 •
edited
Loading

This should become green after googleapis/java-storage#1732 is merged to the main branch and we retry the "downstream / dependencies (11, java-storage)" check.

@suztomo
Copy link
Copy Markdown
Member

suztomo commented Oct 24, 2022

I'm rebasing this pull request to see flatten plugin check.

@suztomo
Copy link
Copy Markdown
Member

suztomo commented Oct 24, 2022

Good. It failed.

+ diff /home/runner/work/java-shared-config/java-shared-config/.kokoro/java-storage-v2.9.3-expected-flattened-dependencies.txt .actual-flattened-dependencies-list.txt
Diff from the expected file (java-storage-v2.9.3-expected-flattened-dependencies.txt):
15a16
> com.google.errorprone:error_prone_annotations:jar:2.14.0:compile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meltsufin meltsufin meltsufin approved these changes

@diegomarquezp diegomarquezp diegomarquezp approved these changes

+1 more reviewer

@alicejli alicejli alicejli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@renovate-bot @suztomo @meltsufin @diegomarquezp @alicejli @yoshi-kokoro