ci: release=8 for JDK 9+#478
Merged
suztomo merged 2 commits intogoogleapis:mainfrom Jun 10, 2022
Merged
Conversation
Member
Author
|
Let's remove "dependencies (8)". #479 |
suztomo
force-pushed
the
release-8-profile
branch
from
d648c9d to
fe41b18
Compare
suztomo
force-pushed
the
release-8-profile
branch
from
fe41b18 to
0dba226
Compare
|
Warning: This pull request is touching the following templated files:
|
suztomo
commented
Jun 10, 2022
| requiresStrictStatusChecks: false | ||
| # List of required status check contexts that must pass for commits to be accepted to matching branches. | ||
| requiredStatusCheckContexts: | ||
| - "dependencies (8)" |
Neenu1995
approved these changes
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #477 . Document: https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html
Having this in the shared config, we can remove the one defined in java-spanner https://github.com/googleapis/java-spanner/blob/a3d08c8e20273cc5e70775933fad1151e0d3a50f/pom.xml#L228. Other libraries will generate Java 8-compatible bytecode when compiling with JDK 11.
Also removing "dependencies (8)" check from this repository.
BEGIN_COMMIT_OVERRIDE
feat: to produce Java 8 compatible bytecode when using JDK 9+
END_COMMIT_OVERRIDE