fix: use recommended variable expansion syntax #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: xs
ldetmer
approved these changes
Apr 15, 2025
diegomarquezp
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
lqiu96
pushed a commit
that referenced
this pull request
May 1, 2025
* fix: use recommended variable expansion syntax * chore: test expansion * chore: automap substitutions * confirm no braces produces the problem * chore: restore c job yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failed build job
Confirmation
$SHORT_SHAdoes not expand the variable in the substitution section as confirmed in this job, associated with e94b259, which produces the wrong valueinfrastructure-public-image-$SHORT_SHA${SHORT_SHA}does expand as confirmed in this job, associated with 760d826, which produces the valueinfrastructure-public-image-760d826