feat: Add flow control support to publisher #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
============================================
+ Coverage 79.36% 79.56% +0.19%
- Complexity 305 308 +3
============================================
Files 21 21
Lines 2603 2701 +98
Branches 115 133 +18
============================================
+ Hits 2066 2149 +83
- Misses 467 477 +10
- Partials 70 75 +5
Continue to review full report at Codecov.
|
hannahrogers-google
approved these changes
Mar 25, 2020
Contributor
hannahrogers-google
left a comment
hannahrogers-google
left a comment
There was a problem hiding this comment.
LGTM. A couple of comments, nothing major
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
Outdated
Show resolved
Hide resolved
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
Outdated
Show resolved
Hide resolved
google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/PublisherImplTest.java
Outdated
Show resolved
Hide resolved
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25