Skip to content

samples: create BigQuery subscription#1168

Merged
anguillanneuf merged 29 commits intogoogleapis:mainfrom
kamalaboulhosn:master
Jun 22, 2022
Merged

samples: create BigQuery subscription#1168
anguillanneuf merged 29 commits intogoogleapis:mainfrom
kamalaboulhosn:master

Conversation

@kamalaboulhosn
Copy link
Copy Markdown
Contributor

No description provided.

@kamalaboulhosn kamalaboulhosn requested review from a team June 17, 2022 17:29
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Jun 17, 2022
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Jun 17, 2022

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels Jun 17, 2022
@kamalaboulhosn kamalaboulhosn requested a review from mmicatka June 17, 2022 17:43
Copy link
Copy Markdown
Contributor

@mmicatka mmicatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. A few nits. Samples tests now pass.

Comment thread samples/snippets/pom.xml Outdated
Comment thread samples/snippets/src/test/java/pubsub/AdminIT.java Outdated
Comment thread samples/snippets/src/test/java/pubsub/AdminIT.java Outdated
@anguillanneuf anguillanneuf added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 21, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 21, 2022
Copy link
Copy Markdown
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@kamalaboulhosn kamalaboulhosn added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 22, 2022
@anguillanneuf
Copy link
Copy Markdown
Contributor

Samples tests will pass when roles propagate. See internal cl/456386109.

@anguillanneuf anguillanneuf added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 22, 2022
@anguillanneuf anguillanneuf added owlbot:ignore instruct owl-bot to ignore a PR and removed owlbot:ignore instruct owl-bot to ignore a PR labels Jun 22, 2022
@anguillanneuf
Copy link
Copy Markdown
Contributor

Added owlbot:ignore by mistake. Owlbot correctly updated README.md.

@anguillanneuf anguillanneuf merged commit d965075 into googleapis:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants