Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

feat: Enable REST transport for most of Java and Go clients#694

Merged
gcf-merge-on-green[bot] merged 4 commits intomainfrom
owl-bot-copy
Jun 24, 2022
Merged

feat: Enable REST transport for most of Java and Go clients#694
gcf-merge-on-green[bot] merged 4 commits intomainfrom
owl-bot-copy

Conversation

@gcf-owl-bot
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jun 23, 2022

  • Regenerate this pull request now.

PiperOrigin-RevId: 456641589

Source-Link: googleapis/googleapis@8a251f5

Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9

@gcf-owl-bot
feat: Enable REST transport for most of Java and Go clients
60c084c 
PiperOrigin-RevId: 456641589

Source-Link: googleapis/googleapis@8a251f5

Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9
@gcf-owl-bot gcf-owl-bot bot requested a review from a team June 23, 2022 02:18
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: oslogin Issues related to the googleapis/java-os-login API. labels Jun 23, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 23, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 23, 2022
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Jun 23, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 23, 2022
@suztomo
Copy link
Member

suztomo commented Jun 23, 2022

@vam-google Do you know anything about this compilation failure?

[INFO] -------------------------------------------------------------
Error:  COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/java-os-login/java-os-login/google-cloud-os-login/src/test/java/com/google/cloud/oslogin/v1/OsLoginServiceClientHttpJsonTest.java:[89,11] no suitable method found for deletePosixAccount(com.google.cloud.oslogin.common.PosixAccountName)
    method com.google.cloud.oslogin.v1.OsLoginServiceClient.deletePosixAccount(com.google.cloud.oslogin.v1.ProjectName) is not applicable
      (argument mismatch; com.google.cloud.oslogin.common.PosixAccountName cannot be converted to com.google.cloud.oslogin.v1.ProjectName)
    method com.google.cloud.oslogin.v1.OsLoginServiceClient.deletePosixAccount(java.lang.String) is not applicable
      (argument mismatch; com.google.cloud.oslogin.common.PosixAccountName cannot be converted to java.lang.String)
    method com.google.cloud.oslogin.v1.OsLoginServiceClient.deletePosixAccount(com.google.cloud.oslogin.v1.DeletePosixAccountRequest) is not applicable
      (argument mismatch; com.google.cloud.oslogin.common.PosixAccountName cannot be converted to com.google.cloud.oslogin.v1.DeletePosixAccountRequest)
Error:  /home/runner/work/java-os-login/java-os-login/google-cloud-os-login/src/test/java/com/google/cloud/oslogin/v1/OsLoginServiceClientHttpJsonTest.java:[115,13] no suitable method found for deletePosixAccount(com.google.cloud.oslogin.common.PosixAccountName)
    method com.google.cloud.oslogin.v1.OsLoginServiceClient.deletePosixAccount(com.google.cloud.oslogin.v1.ProjectName) is not applicable
...

@vam-google
Copy link
Contributor

vam-google commented Jun 23, 2022 •
edited
Loading

@suztomo

This API messes with resource names in post-processing, it also includes GrpcTests. To fix it we need to do similar thing in httpjson tests: https://github.com/googleapis/java-os-login/blob/main/owlbot.py

@gcf-merge-on-green
Copy link

gcf-merge-on-green bot commented Jun 24, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 24, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2022
@Neenu1995 Neenu1995 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 24, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit a72656a into main Jun 24, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-copy branch June 24, 2022 17:14
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 24, 2022
@release-please release-please bot mentioned this pull request Jun 24, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 1, 2022
@release-please
chore(main): release 2.2.0 (#690)
9ec9f4c 
🤖 I have created a release *beep* *boop*
---


## [2.2.0](v2.1.0...v2.2.0) (2022-07-01)


### Features

* Enable REST transport for most of Java and Go clients ([#694](#694)) ([a72656a](a72656a))


### Bug Fixes

* make java.base fields accessible to fix java 17 runtime errors.  ([#688](#688)) ([b262f13](b262f13))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#693](#693)) ([22bd8a0](22bd8a0))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jul 1, 2022
@release-please
chore(main): release 2.2.0 (googleapis#690)
a9d186e 
🤖 I have created a release *beep* *boop*
---


## [2.2.0](googleapis/java-os-login@v2.1.0...v2.2.0) (2022-07-01)


### Features

* Enable REST transport for most of Java and Go clients ([googleapis#694](googleapis/java-os-login#694)) ([a82410e](googleapis/java-os-login@a82410e))


### Bug Fixes

* make java.base fields accessible to fix java 17 runtime errors.  ([googleapis#688](googleapis/java-os-login#688)) ([51a9a6f](googleapis/java-os-login@51a9a6f))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#693](googleapis/java-os-login#693)) ([ecb4469](googleapis/java-os-login@ecb4469))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@suztomo suztomo suztomo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: oslogin Issues related to the googleapis/java-os-login API. owl-bot-copy size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@suztomo @vam-google @Neenu1995 @yoshi-kokoro