Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

chore: mark native image checks as required#665

Merged
mpeddada1 merged 1 commit intomainfrom
require-graal-check
Sep 9, 2022
Merged

chore: mark native image checks as required#665
mpeddada1 merged 1 commit intomainfrom
require-graal-check

Conversation

@mpeddada1
Copy link
Copy Markdown
Contributor

@mpeddada1 mpeddada1 commented Jun 29, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mpeddada1 mpeddada1 requested a review from a team June 29, 2022 14:28
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Jun 29, 2022

Warning: This pull request is touching the following templated files:

  • .github/sync-repo-settings.yaml

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: mediatranslation Issues related to the googleapis/java-mediatranslation API. labels Jun 29, 2022
@alicejli
Copy link
Copy Markdown

alicejli commented Jul 14, 2022 

[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /tmpfs/src/github/java-mediatranslation/samples/snippets/src/main/java/com/example/mediatranslation/TranslateFromFile.java:[85,27] error: cannot find symbol
  symbol:   method getRecognitionResult()
  location: variable res of type StreamingTranslateSpeechResult

@mpeddada1
Copy link
Copy Markdown
Contributor Author

mpeddada1 commented Sep 9, 2022

Thanks for pointing this out @alicejli! Hm interesting, it looks like this failure has been happening for a while now.

@mpeddada1 mpeddada1 merged commit 242b99f into main Sep 9, 2022
@mpeddada1 mpeddada1 deleted the require-graal-check branch September 9, 2022 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@blakeli0 blakeli0 blakeli0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: mediatranslation Issues related to the googleapis/java-mediatranslation API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpeddada1 @alicejli @blakeli0