This repository was archived by the owner on Feb 24, 2026. It is now read-only.
feat: allow flush level OFF#319
Merged
daniel-sanche merged 4 commits intomasterfrom Feb 1, 2021
Merged
Conversation
product-auto-label
Bot
added
the
api: logging
google-cla
Bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
============================================
+ Coverage 69.03% 69.42% +0.39%
- Complexity 40 41 +1
============================================
Files 3 3
Lines 155 157 +2
Branches 17 18 +1
============================================
+ Hits 107 109 +2
Misses 33 33
Partials 15 15
Continue to review full report at Codecov.
|
freelerobot
approved these changes
Feb 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library takes in a FlushLevel argument, which defaults to ERROR. Any logs at that level or higher will be auto-flushed instead of batched.
It appears there is no way to turn the flush level off, forcing all logs to be batched. This PR checks for Level.OFF, and doesn't set the flush level if it is chosen
Fixes #133 ☕️