This repository was archived by the owner on Feb 24, 2026. It is now read-only.
chore: update synth.py to exclude bot configs#300
Merged
gcf-merge-on-green[bot] merged 5 commits intomasterfrom Jan 21, 2021
Merged
chore: update synth.py to exclude bot configs#300gcf-merge-on-green[bot] merged 5 commits intomasterfrom
gcf-merge-on-green[bot] merged 5 commits intomasterfrom
Conversation
added 5 commits
December 10, 2020 10:46
Previously we didn't cleanup trace context so it could cause side effects to some tests as a result of added label in trace context tests. To mitigate this, we added a method to cleanup trace context from MDC as well as invoke it before every test
Previously we didn't cleanup trace context so it could cause side effects to some tests as a result of added label in trace context tests. To mitigate this, we added a method to cleanup trace context from MDC as well as invoke it before every test
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
=========================================
Coverage 69.03% 69.03%
Complexity 40 40
=========================================
Files 3 3
Lines 155 155
Branches 17 17
=========================================
Hits 107 107
Misses 33 33
Partials 15 15
Continue to review full report at Codecov.
|
chingor13
suggested changes
Jan 21, 2021
| java.common_templates() | ||
| java.common_templates(excludes=[ | ||
| '.gitignore', | ||
| '.github/CODEOWNERS', |
Contributor
There was a problem hiding this comment.
We don't want to override CODEOWNERs unless we need to.
chingor13
approved these changes
Jan 21, 2021
daniel-sanche
approved these changes
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude blunderbuss and codeowners from autosynth.
Fixes #299