Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

chore: mark native image checks as required#983

Merged
losalex merged 1 commit intomainfrom
require-graal-check
Jul 19, 2022
Merged

chore: mark native image checks as required#983
losalex merged 1 commit intomainfrom
require-graal-check

Conversation

@mpeddada1
Copy link
Copy Markdown
Contributor

@mpeddada1 mpeddada1 commented Jun 27, 2022

No description provided.

@mpeddada1 mpeddada1 requested review from a team June 27, 2022 21:33
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Jun 27, 2022

Warning: This pull request is touching the following templated files:

  • .github/sync-repo-settings.yaml

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/java-logging API. labels Jun 27, 2022
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2022
@losalex losalex self-assigned this Jul 11, 2022
@losalex losalex added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 11, 2022
losalex
losalex reviewed Jul 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we cannot enable those checks to be mandatory by default unless we add missing integration tests

@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2022
@losalex losalex added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2022
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2022
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2022
@mpeddada1
Copy link
Copy Markdown
Contributor Author

mpeddada1 commented Jul 19, 2022

Currently running into:

com.google.cloud.logging.LoggingException: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Read requests' and limit 'Read requests per minute' of service 'logging.googleapis.com' for consumer 'project_number:1016721519174'.

@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2022
@losalex
Copy link
Copy Markdown
Contributor

losalex commented Jul 19, 2022

Currently running into:

com.google.cloud.logging.LoggingException: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Read requests' and limit 'Read requests per minute' of service 'logging.googleapis.com' for consumer 'project_number:1016721519174'.

We need to wait and retry - unfortunately we must make sure that step "Kokoro - Test: Java 17 GraalVM Native Image" is succeeding

@mpeddada1
Copy link
Copy Markdown
Contributor Author

mpeddada1 commented Jul 19, 2022

Got it, thanks @losalex. Looks like rerunning the jobs did the trick.

@losalex losalex merged commit 2fec337 into main Jul 19, 2022
@losalex losalex deleted the require-graal-check branch July 19, 2022 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@losalex losalex losalex approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@losalex losalex

Labels

api: logging Issues related to the googleapis/java-logging API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpeddada1 @losalex @yoshi-kokoro