Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

chore: change waiting condition for the test#704

Merged
minherz merged 1 commit intomainfrom
minherz/fix-692
Oct 4, 2021
Merged

chore: change waiting condition for the test#704
minherz merged 1 commit intomainfrom
minherz/fix-692

Conversation

@minherz
Copy link
Copy Markdown
Contributor

@minherz minherz commented Oct 3, 2021

change while() condition in testListLogEntriesSample() code.
instead of waiting for first printed log entry it waits for the entry
with designated payload. test will timeout after minute or succeed.

Fixes #692

change while() condition in testListLogEntriesSample() code.
instead of waiting for first printed log entry it waits for the entry
with designated payload. test will timeout after minute or succeed.

Fixes #692
@minherz minherz requested a review from a team October 3, 2021 16:19
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2021
@product-auto-label product-auto-label Bot added the api: logging Issues related to the googleapis/java-logging API. label Oct 3, 2021
Copy link
Copy Markdown
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minherz minherz merged commit 97e6113 into main Oct 4, 2021
@minherz minherz deleted the minherz/fix-692 branch October 4, 2021 07:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/java-logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

com.example.logging.LoggingIT: testListLogEntriesSample failed

3 participants