Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

chore: Update synth.py to exclude codeowners#400

Merged
freelerobot merged 15 commits intogoogleapis:masterfrom
simonz130:fixSynthPy
Jan 22, 2021
Merged

chore: Update synth.py to exclude codeowners#400
freelerobot merged 15 commits intogoogleapis:masterfrom
simonz130:fixSynthPy

Conversation

@simonz130
Copy link
Copy Markdown

@simonz130 simonz130 commented Jan 21, 2021

Prevents autogeneration of github/CODEOWNERS, github/blunderbuss.yml and CONTRIBUTING.md so repo-specific settings are not overridden by bots.

Fixes #399

Simon Zeltser added 14 commits September 23, 2020 18:32
@simonz130 simonz130 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern. api: logging Issues related to the googleapis/java-logging API. automerge Merge the pull request once unit tests and other checks pass. labels Jan 21, 2021
@simonz130 simonz130 requested a review from chingor13 January 21, 2021 18:24
@simonz130 simonz130 self-assigned this Jan 21, 2021
@simonz130 simonz130 requested review from a team January 21, 2021 18:24
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Jan 21, 2021

Warning: This pull request is touching the following templated files:

  • .github/CODEOWNERS

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2021
@simonz130 simonz130 changed the title Fix synth py fix: Update synth.py to exclude codeowners Jan 21, 2021
@chingor13 chingor13 changed the title fix: Update synth.py to exclude codeowners chore: Update synth.py to exclude codeowners Jan 21, 2021
chingor13
chingor13 reviewed Jan 21, 2021
View reviewed changes
Comment thread .github/CODEOWNERS Outdated

# The java-samples-reviewers team is the default owner for samples changes
samples/**/*.java @googleapis/java-samples-reviewers
samples/**/*.java @googleapis/java-samples-reviewers @googleapis/api-logging
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentional to ensure that samples met the Java samples styleguide. We can work on adding folks from the observability team to the samples reviewers group.

Copy link
Copy Markdown
Author

@simonz130 simonz130 Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting this change. It would be useful to get comms on what's happening on the yoshi side - it's not the first time that we discover surprise changes in the repos we own without prior communication.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2021 •
edited
Loading

Codecov Report

Merging #400 (c506be3) into master (1e5a876) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #400   +/-   ##
=========================================
  Coverage     76.67%   76.67%           
  Complexity      680      680           
=========================================
  Files            44       44           
  Lines          4249     4249           
  Branches        287      287           
=========================================
  Hits           3258     3258           
  Misses          826      826           
  Partials        165      165
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/google/cloud/logging/SinkInfo.java 80.69% <100.00%> (ø) 19.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e5a876...c506be3. Read the comment docs.

chingor13
chingor13 suggested changes Jan 21, 2021
View reviewed changes
Comment thread synth.py
java.common_templates()
java.common_templates(excludes=[
'.gitignore',
'.github/CODEOWNERS',
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really don't want to drift on the CODEOWNERs files unless we have a big need to

@freelerobot freelerobot merged commit c61ee85 into googleapis:master Jan 22, 2021
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 22, 2021
@simonz130 simonz130 deleted the fixSynthPy branch January 22, 2021 00:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@averikitsch averikitsch Awaiting requested review from averikitsch

@kurtisvg kurtisvg Awaiting requested review from kurtisvg

2 more reviewers

@chingor13 chingor13 chingor13 approved these changes

@freelerobot freelerobot freelerobot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@simonz130 simonz130

Labels

api: logging Issues related to the googleapis/java-logging API. cla: yes This human has signed the Contributor License Agreement. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: cleanup An internal cleanup or hygiene concern.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add blunderbuss config into synth.py to prevent override by authosynth

3 participants

@simonz130 @chingor13 @freelerobot