Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

ci: unmanaged dependency check#1521

Merged
suztomo merged 2 commits intomainfrom
unmanaged_dependencies_check
Jan 26, 2024
Merged

ci: unmanaged dependency check#1521
suztomo merged 2 commits intomainfrom
unmanaged_dependencies_check

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Jan 25, 2024

Cindy has reviewed go/cloud-sdk-java-dependency-governance-design. This new check would fail if someone adds an unknown new dependency to pom.xml files. All new dependencies should be added in https://github.com/googleapis/sdk-platform-java/blob/main/java-shared-dependencies/third-party-dependencies/pom.xml first.

@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: logging Issues related to the googleapis/java-logging API. labels Jan 25, 2024
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Jan 25, 2024

Unmanaged dependency check / unmanaged_dependency_check (pull_request) Successful

@suztomo suztomo requested a review from cindy-peng January 25, 2024 21:59
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Jan 25, 2024

@cindy-peng This is the check discussed in go/cloud-sdk-java-dependency-governance-design and we are gradually rolling out to the repositories. PTAL.

@suztomo suztomo marked this pull request as ready for review January 25, 2024 22:00
@suztomo suztomo requested review from a team January 25, 2024 22:00
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 26, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 26, 2024
Copy link
Copy Markdown
Contributor

@cindy-peng cindy-peng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tomo for working on this!

@suztomo suztomo merged commit 7926233 into main Jan 26, 2024
@suztomo suztomo deleted the unmanaged_dependencies_check branch January 26, 2024 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/java-logging API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants