samples: firestore beam connector examples#966
Merged
gcf-merge-on-green[bot] merged 8 commits intogoogleapis:mainfrom Jun 27, 2022
Merged
samples: firestore beam connector examples#966gcf-merge-on-green[bot] merged 8 commits intogoogleapis:mainfrom
gcf-merge-on-green[bot] merged 8 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
the
api: firestore
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
the
samples
gcf-owl-bot
bot
removed
the
owlbot:run
kolea2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
Shabirmean
reviewed
Jun 18, 2022
samples/snippets/src/main/java/com/example/firestore/beam/ExampleFirestoreBeamRead.java
Show resolved
Hide resolved
Shabirmean
reviewed
Jun 18, 2022
samples/snippets/src/main/java/com/example/firestore/beam/ExampleFirestoreBeamRead.java
Show resolved
Hide resolved
Shabirmean
reviewed
Jun 18, 2022
samples/snippets/src/main/java/com/example/firestore/beam/ExampleFirestoreBeamRead.java
Show resolved
Hide resolved
Shabirmean
reviewed
Jun 18, 2022
samples/snippets/src/main/java/com/example/firestore/beam/ExampleFirestoreBeamWrite.java
Show resolved
Hide resolved
Shabirmean
reviewed
Jun 18, 2022
| .setUpdate( | ||
| Document.newBuilder() | ||
| // resolves to | ||
| // projects/<your-project-id>/databases/<your-database-id>/documents/cities/NYC |
There was a problem hiding this comment.
can we refer to the collectionId as collectionId or databaseId in both the variable and the comment, instead of using different terms?
Shabirmean
reviewed
Jun 18, 2022
| .setUpdate( | ||
| Document.newBuilder() | ||
| // resolves to | ||
| // projects/<your-project-id>/databases/<your-database-id>/documents/cities/TOK |
Shabirmean
reviewed
Jun 18, 2022
Shabirmean
left a comment
Shabirmean
left a comment
There was a problem hiding this comment.
LGTM overall. Left some comments around code format!
kolea2
added
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
kolea2
added
the
automerge
telpirion
approved these changes
Jun 27, 2022
gcf-merge-on-green
bot
removed
the
automerge
cherylEnkidu
pushed a commit
that referenced
this pull request
Dec 11, 2023
Note this normally would go in java-docs-samples, but putting here as this project is already configured for Firestore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note this normally would go in java-docs-samples, but putting here as this project is already configured for Firestore.