tests: add coverage for a successful read-only transaction with readTime#870
Merged
cherylEnkidu merged 1 commit intomainfrom Feb 14, 2022
Merged
tests: add coverage for a successful read-only transaction with readTime#870cherylEnkidu merged 1 commit intomainfrom
cherylEnkidu merged 1 commit intomainfrom
Conversation
cherylEnkidu
added
the
api: firestore
cherylEnkidu
force-pushed
the
cheryllin/readtimeTest
branch
2 times, most recently
from
d01d1ed to
d6dde51
Compare
Contributor
schmidt-sebastian
left a comment
schmidt-sebastian
left a comment
There was a problem hiding this comment.
This is great! Thank you for doing this.
One thing to read up on is https://www.conventionalcommits.org/en/v1.0.0/
The TL/DR is that the repo tooling using the PR title to generate releases. This means that your PR has to follow the prescribed pattern. You could use a name as such:
tests: add coverage for a successful read-only transaction with readTime
Note that this only applies to Java and Node.
| final DocumentSnapshot snapshot = | ||
| transaction.get(documentReference).get(5, TimeUnit.SECONDS); | ||
| ref.compareAndSet(null, snapshot); | ||
| return null; |
Contributor
There was a problem hiding this comment.
You could just return the value of the counter here. Then this transaction returns an ApiFuture<Integer> and you don't have to copy the document state.
| documentReference.set(Collections.singletonMap("counter", 1)).get().getUpdateTime(); | ||
| documentReference.set(Collections.singletonMap("counter", 2)).get(); | ||
|
|
||
| final TransactionOptions option = |
cherylEnkidu
changed the title
cherylEnkidu
force-pushed
the
cheryllin/readtimeTest
branch
from
d6dde51 to
331315a
Compare
schmidt-sebastian
approved these changes
Feb 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test to cover the a successful transaction with readTime set before the last time changing the document.