Skip to content

chore: make FirestoreException factory methods public to allow construction for testing#477

Merged
BenWhitehead merged 1 commit intogoogleapis:masterfrom
BenWhitehead:public-firestore-exception-methods
Jan 15, 2021
Merged

chore: make FirestoreException factory methods public to allow construction for testing#477
BenWhitehead merged 1 commit intogoogleapis:masterfrom
BenWhitehead:public-firestore-exception-methods

Conversation

@BenWhitehead
Copy link
Copy Markdown
Contributor

@BenWhitehead BenWhitehead commented Nov 25, 2020

  • Expose each factory method at @BetaApi level ensuring no guarantee about api surface
  • Expose getStatus() at @BetaApi up from package private @internalapi

@BenWhitehead BenWhitehead requested review from a team November 25, 2020 20:08
@product-auto-label product-auto-label Bot added the api: firestore Issues related to the googleapis/java-firestore API. label Nov 25, 2020
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 25, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 25, 2020 •
edited
Loading

Codecov Report

Merging #477 (87bf1a9) into master (d17e17c) will decrease coverage by 0.02%.
The diff coverage is 48.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #477      +/-   ##
============================================
- Coverage     74.45%   74.43%   -0.03%     
+ Complexity     1117     1108       -9     
============================================
  Files            66       66              
  Lines          5853     5855       +2     
  Branches        724      726       +2     
============================================
  Hits           4358     4358              
- Misses         1267     1269       +2     
  Partials        228      228
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/firestore/CollectionGroup.java 18.91% <0.00%> (ø) 1.00 <0.00> (ø)
...om/google/cloud/firestore/CollectionReference.java 43.75% <0.00%> (ø) 10.00 <0.00> (ø)
.../com/google/cloud/firestore/DocumentReference.java 70.32% <0.00%> (ø) 31.00 <0.00> (ø)
...a/com/google/cloud/firestore/FirestoreOptions.java 35.89% <0.00%> (ø) 7.00 <0.00> (ø)
...rc/main/java/com/google/cloud/firestore/Query.java 88.16% <0.00%> (ø) 147.00 <0.00> (-7.00)
...java/com/google/cloud/firestore/UpdateBuilder.java 94.97% <0.00%> (ø) 59.00 <0.00> (ø)
.../com/google/cloud/firestore/UserDataConverter.java 95.37% <0.00%> (-0.90%) 37.00 <0.00> (ø)
...rc/main/java/com/google/cloud/firestore/Watch.java 91.30% <50.00%> (-0.40%) 56.00 <0.00> (ø)
...va/com/google/cloud/firestore/BulkCommitBatch.java 93.05% <100.00%> (ø) 18.00 <0.00> (ø)
.../com/google/cloud/firestore/BulkWriterOptions.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17e17c...87bf1a9. Read the comment docs.

schmidt-sebastian
schmidt-sebastian approved these changes Jan 8, 2021
View reviewed changes
Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreException.java Outdated
Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreException.java Outdated
Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreException.java Outdated
Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreException.java Outdated
yoshi-code-bot
yoshi-code-bot reviewed Jan 11, 2021
View reviewed changes
Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/CollectionReference.java Outdated
Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreException.java Outdated
Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java Outdated
Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/UserDataConverter.java Outdated
Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/UserDataConverter.java Outdated
Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/Watch.java Outdated
@BenWhitehead
chore: make FirestoreException factory methods public to allow constr…
87bf1a9 
…uction for testing

* Expose each factory method at @BetaApi level ensuring no guarantee about api surface
* Expose getStatus() at @BetaApi up from package private @internalapi
@BenWhitehead BenWhitehead merged commit 23d5415 into googleapis:master Jan 15, 2021
@BenWhitehead BenWhitehead deleted the public-firestore-exception-methods branch January 15, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@yoshi-code-bot yoshi-code-bot yoshi-code-bot left review comments

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BenWhitehead BenWhitehead

Labels

api: firestore Issues related to the googleapis/java-firestore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BenWhitehead @schmidt-sebastian @yoshi-code-bot