Skip to content

fix: Migrate off GeneratedMessageV3#1692

Merged
tom-andersen merged 2 commits intomainfrom
pbj426-compatibility
May 21, 2024
Merged

fix: Migrate off GeneratedMessageV3#1692
tom-andersen merged 2 commits intomainfrom
pbj426-compatibility

Conversation

@lqiu96
Copy link
Copy Markdown
Member

@lqiu96 lqiu96 commented May 20, 2024

Fixes: #1690

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/java-firestore API. labels May 20, 2024
@lqiu96 lqiu96 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 20, 2024
@lqiu96 lqiu96 marked this pull request as ready for review May 20, 2024 19:10
@lqiu96 lqiu96 requested a review from a team as a code owner May 20, 2024 19:10
@tom-andersen tom-andersen merged commit 44c26e9 into main May 21, 2024
@tom-andersen tom-andersen deleted the pbj426-compatibility branch May 21, 2024 14:27
import com.google.firestore.v1.Value;
import com.google.firestore.v1.Write;
import com.google.protobuf.GeneratedMessageV3;
import com.google.protobuf.AbstractMessage;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the Message interface instead?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in #1709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Library Compatibility with Protobuf-Java 4.26.x+

3 participants