Merged
Conversation
product-auto-label
bot
added
size: l
MarkDuckworth
approved these changes
Jun 30, 2023
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
LGTM, other than one comment that may just be me lacking info about why the commented line was changed.
|
|
||
| @Test | ||
| public void limitToLastRequiresAtLeastOneOrderingConstraint() throws Exception { | ||
| doAnswer(queryResponse()) |
Contributor
There was a problem hiding this comment.
Was it intentional to remove the doAnswer(...)... block from this test and the test below?
Contributor
Author
There was a problem hiding this comment.
Mockito has become strict, and will fail test if mocked behaviour isn't used. So I removed mocked behaviour.
Contributor
Author
cherylEnkidu
pushed a commit
that referenced
this pull request
Dec 11, 2023
* mockito 4 * Replaced old class with new class * format * Make Mockito lenient (no failure, even if mock never used). * Make Mockito lenient (no failure, even if mock never used). * Fix test * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Remove unused mock * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Static import for simpler code. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Tomo Suzuki <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.