Skip to content

test: upgrading Mockito to v4#1344

Closed
suztomo wants to merge 3 commits intogoogleapis:mainfrom
suztomo:mockito3
Closed

test: upgrading Mockito to v4#1344
suztomo wants to merge 3 commits intogoogleapis:mainfrom
suztomo:mockito3

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Jun 23, 2023 •
edited
Loading

Fixes #1342

Another approach than #1343

@suztomo suztomo requested a review from a team June 23, 2023 14:33
@suztomo suztomo requested a review from a team as a code owner June 23, 2023 14:33
@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf bot commented Jun 23, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/java-firestore API. labels Jun 23, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xs Pull request size is extra small. labels Jun 23, 2023
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Jun 23, 2023

Now the unit tests do not finish for ConformanceTest. My local run:

[INFO] --- maven-surefire-plugin:3.1.0:test (default-test) @ google-cloud-firestore ---
[INFO] Using auto detected provider org.apache.maven.surefire.junit4.JUnit4Provider
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.google.cloud.firestore.v1.FirestoreClientHttpJsonTest
[INFO] Tests run: 30, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.69 s - in com.google.cloud.firestore.v1.FirestoreClientHttpJsonTest
[INFO] Running com.google.cloud.firestore.v1.FirestoreClientTest
[INFO] Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.682 s - in com.google.cloud.firestore.v1.FirestoreClientTest
[INFO] Running com.google.cloud.firestore.CollectionReferenceTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.428 s - in com.google.cloud.firestore.CollectionReferenceTest
[INFO] Running com.google.cloud.firestore.ConformanceTest

Even after I skip ConformanceTest (mvn test -am -pl google-cloud-firestore -Dtest='!ConformanceTest' -Dsurefire.failIfNoSpecifiedTests=false) there are test failures. https://gist.github.com/suztomo/c6766c949f910ff3f77a1782b3f31779 Giving up this pull request in favor of #1343

@suztomo suztomo mentioned this pull request Jun 23, 2023
Merged
suztomo
suztomo commented Jun 23, 2023
View reviewed changes
google-cloud-firestore/pom.xml
<artifactId>mockito-all</artifactId>
<version>1.10.19</version>
<artifactId>mockito-core</artifactId>
<version>4.11.0</version>
Copy link
Copy Markdown
Member Author

@suztomo suztomo Jun 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This 4.11.0 is on par with java-storage's setup https://github.com/googleapis/java-storage/blob/6d4f851d96cac6c40f214e4d3de032e0500ba7a0/pom.xml#L108

@suztomo suztomo closed this Jun 26, 2023
@tom-andersen tom-andersen reopened this Jun 27, 2023
@tom-andersen tom-andersen self-assigned this Jun 27, 2023
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Jun 27, 2023

@tom-andersen If you can make this Mockito upgrade work (which is great), then the profile added in #1343 (merged) can be removed.

@tom-andersen
Copy link
Copy Markdown
Contributor

tom-andersen commented Jun 27, 2023

Continuing PR in different branch:
#1345

@tom-andersen tom-andersen mentioned this pull request Jul 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tom-andersen tom-andersen

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"units (17)" check has been failing due to mockito

2 participants

@suztomo @tom-andersen