Skip to content

ci: Java 17 profile to run tests with old Mockito#1343

Merged
suztomo merged 1 commit intogoogleapis:mainfrom
suztomo:i1342
Jun 27, 2023
Merged

ci: Java 17 profile to run tests with old Mockito#1343
suztomo merged 1 commit intogoogleapis:mainfrom
suztomo:i1342

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Jun 23, 2023

Fixes #1342

This is an idea to fix the problem. Creating another PR to upgrade Mockito. => #1344 turned out many errors. So I'm for this #1343.

@suztomo suztomo requested a review from a team June 23, 2023 14:24
@suztomo suztomo requested a review from a team as a code owner June 23, 2023 14:24
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/java-firestore API. labels Jun 23, 2023
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Jun 23, 2023

ci / units (17) (pull_request) Successful in 1m

@suztomo suztomo requested a review from tom-andersen June 23, 2023 14:55
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 23, 2023
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Jun 26, 2023

@googleapis/api-firestore Would you review this change to fix Java 17 unit test?

Copy link
Copy Markdown
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"units (17)" check has been failing due to mockito

2 participants