feat: Add long alias support for aggregations.#1267
Merged
ehsannas merged 6 commits intoehsann/sum-averagefrom Aug 2, 2023
Merged
feat: Add long alias support for aggregations.#1267ehsannas merged 6 commits intoehsann/sum-averagefrom
ehsannas merged 6 commits intoehsann/sum-averagefrom
Conversation
product-auto-label
bot
added
size: s
ehsannas
changed the title
ehsannas
force-pushed
the
ehsann/long-alias
branch
from
a12a29d to
5dcc233
Compare
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
LGTM other than the test that uses field names longer than 1500-bytes
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryAggregationsTest.java
Outdated
Show resolved
Hide resolved
| String serverAlias = "aggregate_" + aggregationNum++; | ||
| aliasMap.put(serverAlias, aggregateField.getAlias()); | ||
| aggregation.setAlias(serverAlias); | ||
| aggregations.add(aggregation.build()); |
Contributor
There was a problem hiding this comment.
will the deduplication still work?
Contributor
Author
There was a problem hiding this comment.
My understanding is:
duplicate aliases are not allowed
duplicate aggregates are allowed
is that right @cherylEnkidu @MarkDuckworth ?
this code uses aggregate_<counter> as alias, so there should not be any duplicate aliases.
also, there's a test named canGetDuplicateAggregations below which currently passes against the emulator.
Contributor
Author
There was a problem hiding this comment.
ah... it's coming back to me now... I believe we decided to remove duplicate aggregates even though they are allowed to improve performance.
Contributor
Author
There was a problem hiding this comment.
Done.
Followed what was done in Android. PTAL.
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryAggregationsTest.java
Show resolved
Hide resolved
product-auto-label
bot
added
size: m
MarkDuckworth
approved these changes
Jul 28, 2023
| String serverAlias = "aggregate_" + aggregationNum++; | ||
| aliasMap.put(serverAlias, aggregateField.getAlias()); | ||
| aggregation.setAlias(serverAlias); | ||
| aggregations.add(aggregation.build()); |
Contributor
Author
|
The CI is expected to fail (uses prod) |
ehsannas
added a commit
that referenced
this pull request
Aug 2, 2023
* feat: Add long alias support for aggregations. * address comments. * Better method name and replace hardcoded "count" with "aggregate_0". * Remove duplicate aggregations. * add static import. * Fix tests. All tests pass.
ehsannas
added a commit
that referenced
this pull request
Aug 2, 2023
* feat: Add long alias support for aggregations. * address comments. * Better method name and replace hardcoded "count" with "aggregate_0". * Remove duplicate aggregations. * add static import. * Fix tests. All tests pass.
ehsannas
added a commit
that referenced
this pull request
Aug 2, 2023
* feat: Add long alias support for aggregations. * address comments. * Better method name and replace hardcoded "count" with "aggregate_0". * Remove duplicate aggregations. * add static import. * Fix tests. All tests pass.
ehsannas
added a commit
that referenced
this pull request
Oct 9, 2023
* feat: SUM / AVG (#1218) * feat: SUM / AVG (real files) * Remove aggregate field duplicates (if any). * Clean up and fixes. * Clean up comments, and add Nonnull where possible. * Add more public docs. * More cleanup. * Update hashCode and equals for AggregateQuery. * Address code review comments. more to come. * fix test name. * Better comment. * Fix alias encoding. * Remove TODO. * Revert the way alias is constructed. * Backport test updates. fix format. fix import stmt. * feat: Add long alias support for aggregations. (#1267) * feat: Add long alias support for aggregations. * address comments. * Better method name and replace hardcoded "count" with "aggregate_0". * Remove duplicate aggregations. * add static import. * Fix tests. All tests pass. * Address comments. * Improve the documentation to match strongly typed languages. * Do not use wildcard import. * Do not use wildcard import (2). * Do not use wildcard import (3). * Do not use wildcard import (4). * Fix the javadoc. * Add license header, and remove unused test code. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * better regex. * Add more tests for cursors. --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
cherylEnkidu
pushed a commit
that referenced
this pull request
Dec 11, 2023
* feat: SUM / AVG (#1218) * feat: SUM / AVG (real files) * Remove aggregate field duplicates (if any). * Clean up and fixes. * Clean up comments, and add Nonnull where possible. * Add more public docs. * More cleanup. * Update hashCode and equals for AggregateQuery. * Address code review comments. more to come. * fix test name. * Better comment. * Fix alias encoding. * Remove TODO. * Revert the way alias is constructed. * Backport test updates. fix format. fix import stmt. * feat: Add long alias support for aggregations. (#1267) * feat: Add long alias support for aggregations. * address comments. * Better method name and replace hardcoded "count" with "aggregate_0". * Remove duplicate aggregations. * add static import. * Fix tests. All tests pass. * Address comments. * Improve the documentation to match strongly typed languages. * Do not use wildcard import. * Do not use wildcard import (2). * Do not use wildcard import (3). * Do not use wildcard import (4). * Fix the javadoc. * Add license header, and remove unused test code. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * better regex. * Add more tests for cursors. --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.