Skip to content

chore: use require-hashes option#1078

Merged
mpeddada1 merged 4 commits intomainfrom
tomandersen/floatingDependency
Oct 31, 2022
Merged

chore: use require-hashes option#1078
mpeddada1 merged 4 commits intomainfrom
tomandersen/floatingDependency

Conversation

@tom-andersen
Copy link
Copy Markdown
Contributor

@tom-andersen tom-andersen commented Oct 25, 2022

No description provided.

@generated-files-bot
Copy link
Copy Markdown

generated-files-bot bot commented Oct 25, 2022

Warning: This pull request is touching the following templated files:

  • .kokoro/release/publish_javadoc.sh
  • .kokoro/release/publish_javadoc11.sh
  • .kokoro/release/stage.sh
  • renovate.json

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Oct 25, 2022
@tom-andersen tom-andersen marked this pull request as ready for review October 25, 2022 17:28
@tom-andersen tom-andersen requested a review from a team October 25, 2022 17:28
@tom-andersen tom-andersen requested a review from a team as a code owner October 25, 2022 17:28
@mpeddada1
Copy link
Copy Markdown
Contributor

mpeddada1 commented Oct 25, 2022

@tom-andersen noticed that the synthtool PRs didn't show up in the repository (for example, googleapis/java-texttospeech#759). Is this expected?

@tom-andersen tom-andersen requested a review from ehsannas October 25, 2022 18:10
@tom-andersen tom-andersen added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 25, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 25, 2022
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2022
mpeddada1
mpeddada1 reviewed Oct 26, 2022
View reviewed changes
@suztomo suztomo mentioned this pull request Oct 28, 2022
Merged
@mpeddada1 mpeddada1 added the owlbot:ignore instruct owl-bot to ignore a PR label Oct 28, 2022
@mpeddada1
Copy link
Copy Markdown
Contributor

mpeddada1 commented Oct 28, 2022

@tom-andersen The versions in the requirements.txt file look great. I'm afraid owlbot overwrote some of the changes so we'll need to bring these back (1c5e4a9) I've added the owlbot:ignore label which should hopefully prevent this from happening again.

@tom-andersen
Copy link
Copy Markdown
Contributor Author

tom-andersen commented Oct 31, 2022

@mpeddada1 I have reverted the Owl Bot change.

mpeddada1
mpeddada1 approved these changes Oct 31, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mpeddada1 mpeddada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @tom-andersen! LGTM

@mpeddada1 mpeddada1 merged commit c7ac9ed into main Oct 31, 2022
@mpeddada1 mpeddada1 deleted the tomandersen/floatingDependency branch October 31, 2022 14:39
cherylEnkidu pushed a commit that referenced this pull request Dec 11, 2023
@tom-andersen @cherylEnkidu
chore: use require-hashes option (#1078)
c826698 
* chore: use require-hashes option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsannas ehsannas Awaiting requested review from ehsannas

1 more reviewer

@mpeddada1 mpeddada1 mpeddada1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ehsannas ehsannas

@mpeddada1 mpeddada1

Labels

api: firestore Issues related to the googleapis/java-firestore API. owlbot:ignore instruct owl-bot to ignore a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tom-andersen @mpeddada1 @ehsannas @yoshi-kokoro