chore: Use firestore-jar to determine grpc version#1076
Merged
Conversation
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
the
api: firestore
Member
Author
|
It seems the beam dependencies were pulling in the older versions of the I'll need figure out the warning with the snapshot jar being templated. |
gcf-owl-bot
bot
removed
the
owlbot:run
dconeybe
approved these changes
Oct 26, 2022
Contributor
dconeybe
left a comment
dconeybe
left a comment
There was a problem hiding this comment.
LGTM. Thanks for making this fix! The failing GitHub Action was such a nuisance. Plus, now the test coverage that the samples provide can be restored.
cherylEnkidu
pushed a commit
that referenced
this pull request
Dec 11, 2023
* chore: Use firestore-jar to determine grpc version * chore: Add samples pom.xml to owlbot processor exlcusion list * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[WIP] This is to test our theory about the GRPC jars
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1075 ☕️