test: Re-enable aggregateQueryInATransactionShouldRespectReadTime when run against the emulator#1050
Merged
dconeybe merged 1 commit intodconeybe/CountReleasefrom Sep 30, 2022
Conversation
…n run against the emulator
dconeybe
added
the
api: firestore
Contributor
Author
|
Meh, I'm just going to merge this. Don't worry about the code review. |
dconeybe
deleted the
dconeybe/ReEnableAggregateQueryInATransactionShouldRespectReadTimeOnEmulator
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #1044, which disabled the test
aggregateQueryInATransactionShouldRespectReadTimebecause of a known issue: b/220918135 (When creating a new read-only or read-write transaction, the Firestore emulator creates the transaction at the current time regardless of the user's specified TransactionsOptions. In the case of read-only transaction, if the user specifies the read_time, that will not be honoured. If the user specifies a retry_transaction, that will not be honored).The issue has been confirmed fixed in
cloud-firestore-emulator-v1.15.1.jar, so skipping the test is no longer required. This PR re-enables the test when run against he Firestore Emulator.