Conversation
… against the emulator (b/220918135)
dconeybe
added
the
api: firestore
Contributor
Author
|
It looks like b/220918135 is actually fixed. I've inquired to see if it will be released any time soon. |
Contributor
Author
|
cl/472994416, once submitted, will release a new version of the Firestore emulator with a fix for b/220918135. |
dconeybe
added a commit
that referenced
this pull request
Sep 23, 2022
…ctionShouldRespectReadTime when run against the emulator to its own PR: #1044
…TransactionShouldRespectReadTimeOnEmulator
wu-hui
approved these changes
Sep 23, 2022
dconeybe
deleted the
dconeybe/SkipAggregateQueryInATransactionShouldRespectReadTimeOnEmulator
branch
cherylEnkidu
pushed a commit
that referenced
this pull request
Dec 11, 2023
… against the emulator (b/220918135) (#1044)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test aggregateQueryInATransactionShouldRespectReadTime fails when run against the Firestore emulator due to a known issue: b/220918135 (When creating a new read-only or read-write transaction, the Firestore emulator creates the transaction at the current time regardless of the user's specified TransactionsOptions. In the case of read-only transaction, if the user specifies the read_time, that will not be honoured. If the user specifies a retry_transaction, that will not be honored).
Instead of letting the test fail, this PR has it be skipped with an appropriate error message.