Conversation
…unning against prod (b/248152832)
…s when running against prod (b/248152832)" This reverts commit 1754322.
dconeybe
added
the
api: firestore
Base automatically changed from
dconeybe/EnableITQueryCountTestInCI
to
main
September 23, 2022 02:28
…QueryInATransactionShouldLockTheCountedDocuments
…eCountedDocuments to do what I had expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
aggregateQueryInATransactionShouldLockTheCountedDocumentswas disabled in #1040 because it failed when running against production.I need to check if this is a bug in the backend or a faulty test. This test passes against the Firestore emulator.
Here is the line in the test that is failing:
java-firestore/google-cloud-firestore/src/test/java/com/google/cloud/firestore/ITQueryCountTest.java
Line 238 in a7e90dd
I've opened b/248152832 to investigate.
Once the issue is fixed, merge this PR to re-enable the test.