Skip to content

feat: Make count queries publicly available for use#1042

Merged
dconeybe merged 12 commits intomainfrom
dconeybe/CountRelease
Oct 3, 2022
Merged

feat: Make count queries publicly available for use#1042
dconeybe merged 12 commits intomainfrom
dconeybe/CountRelease

Conversation

@dconeybe
Copy link
Copy Markdown
Contributor

@dconeybe dconeybe commented Sep 22, 2022

This PR changes the visibility of classes and methods that provide "count" queries from default to public, making them available for anyone to use. See #1033 for the implementation of COUNT queries.

@dconeybe dconeybe added the api: firestore Issues related to the googleapis/java-firestore API. label Sep 22, 2022
@dconeybe dconeybe self-assigned this Sep 22, 2022
@dconeybe dconeybe requested a review from a team as a code owner September 22, 2022 03:29
@dconeybe dconeybe marked this pull request as draft September 22, 2022 03:30
@dconeybe dconeybe requested a review from ehsannas September 23, 2022 15:15
@ehsannas ehsannas added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2022
@dconeybe dconeybe added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 24, 2022
@dconeybe dconeybe marked this pull request as ready for review September 26, 2022 13:41
@ehsannas ehsannas added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 26, 2022
@ehsannas
Copy link
Copy Markdown
Contributor

ehsannas commented Sep 26, 2022

LGTM. Marked as "do not merge" for now.

@dconeybe dconeybe removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 3, 2022
@dconeybe dconeybe merged commit 1c8d242 into main Oct 3, 2022
@dconeybe dconeybe deleted the dconeybe/CountRelease branch October 3, 2022 17:33
@release-please release-please bot mentioned this pull request Oct 4, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 5, 2022
@release-please
chore(main): release 3.6.0 (#1054)
4686b77 
🤖 I have created a release *beep* *boop*
---


## [3.6.0](https://togithub.com/googleapis/java-firestore/compare/v3.5.0...v3.6.0) (2022-10-04)


### Features

* Count queries (not available for use yet) ([#1033](https://togithub.com/googleapis/java-firestore/issues/1033)) ([8b60612](https://togithub.com/googleapis/java-firestore/commit/8b60612f1922a4c377fac357ee7f4304362622f3))
* Make count queries publicly available for use ([#1042](https://togithub.com/googleapis/java-firestore/issues/1042)) ([1c8d242](https://togithub.com/googleapis/java-firestore/commit/1c8d2428d94ab8b3c18a8cad14daa2a1e39af369))


### Documentation

* AggregateQuery.java: describe why we ignore subsequent responses ([#1041](https://togithub.com/googleapis/java-firestore/issues/1041)) ([8150544](https://togithub.com/googleapis/java-firestore/commit/8150544aee0aa04a5e6239dbc4994ddd056393ba))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#1053](https://togithub.com/googleapis/java-firestore/issues/1053)) ([9b4c26e](https://togithub.com/googleapis/java-firestore/commit/9b4c26eac062fa73c8b275978f35c5bfb8cdfc21))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.14 ([#1045](https://togithub.com/googleapis/java-firestore/issues/1045)) ([04b3861](https://togithub.com/googleapis/java-firestore/commit/04b3861d874dcd63713e62bd7717097ca8f68a3c))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.14 ([#1046](https://togithub.com/googleapis/java-firestore/issues/1046)) ([6631a58](https://togithub.com/googleapis/java-firestore/commit/6631a58553a12e1f48d060d0b87cfa8683492b94))
* Update dependency org.junit.vintage:junit-vintage-engine to v5.9.1 ([#1039](https://togithub.com/googleapis/java-firestore/issues/1039)) ([84423f4](https://togithub.com/googleapis/java-firestore/commit/84423f4db6e35f9d30a34a5bc2d29050380840ec))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
cherylEnkidu pushed a commit that referenced this pull request Dec 11, 2023
@dconeybe @cherylEnkidu
feat: Make count queries publicly available for use (#1042)
aa75e0d
cherylEnkidu pushed a commit that referenced this pull request Dec 11, 2023
@release-please @cherylEnkidu
chore(main): release 3.6.0 (#1054)
663118d 
🤖 I have created a release *beep* *boop*
---


## [3.6.0](https://togithub.com/googleapis/java-firestore/compare/v3.5.0...v3.6.0) (2022-10-04)


### Features

* Count queries (not available for use yet) ([#1033](https://togithub.com/googleapis/java-firestore/issues/1033)) ([8b60612](https://togithub.com/googleapis/java-firestore/commit/8b60612f1922a4c377fac357ee7f4304362622f3))
* Make count queries publicly available for use ([#1042](https://togithub.com/googleapis/java-firestore/issues/1042)) ([1c8d242](https://togithub.com/googleapis/java-firestore/commit/1c8d2428d94ab8b3c18a8cad14daa2a1e39af369))


### Documentation

* AggregateQuery.java: describe why we ignore subsequent responses ([#1041](https://togithub.com/googleapis/java-firestore/issues/1041)) ([8150544](https://togithub.com/googleapis/java-firestore/commit/8150544aee0aa04a5e6239dbc4994ddd056393ba))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#1053](https://togithub.com/googleapis/java-firestore/issues/1053)) ([9b4c26e](https://togithub.com/googleapis/java-firestore/commit/9b4c26eac062fa73c8b275978f35c5bfb8cdfc21))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.14 ([#1045](https://togithub.com/googleapis/java-firestore/issues/1045)) ([04b3861](https://togithub.com/googleapis/java-firestore/commit/04b3861d874dcd63713e62bd7717097ca8f68a3c))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.14 ([#1046](https://togithub.com/googleapis/java-firestore/issues/1046)) ([6631a58](https://togithub.com/googleapis/java-firestore/commit/6631a58553a12e1f48d060d0b87cfa8683492b94))
* Update dependency org.junit.vintage:junit-vintage-engine to v5.9.1 ([#1039](https://togithub.com/googleapis/java-firestore/issues/1039)) ([84423f4](https://togithub.com/googleapis/java-firestore/commit/84423f4db6e35f9d30a34a5bc2d29050380840ec))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@dconeybe dconeybe

Labels

api: firestore Issues related to the googleapis/java-firestore API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dconeybe @ehsannas