feat: add firestore aggregation query apis to the stable googleapis branch by gcf-owl-bot[bot] · Pull Request #1030 · googleapis/java-firestore

gcf-owl-bot · 2022-09-07T19:44:43Z

Regenerate this pull request now.

PiperOrigin-RevId: 473753776

Source-Link: googleapis/googleapis@a8c6c7c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/6e3b0d6ead4265ca6f0ad3e1829f4e3a5bc109a2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmUzYjBkNmVhZDQyNjVjYTZmMGFkM2UxODI5ZjRlM2E1YmMxMDlhMiJ9

chore(bazel): Update WORKSPACE files for rules_gapic, gax_java, generator_java versions

PiperOrigin-RevId: 472750037

Source-Link: googleapis/googleapis@88f2ea3

Source-Link: https://github.com/googleapis/googleapis-gen/commit/230a5588306aae18fe8f2a57f14d4039ad72c901
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9

gcf-merge-on-green · 2022-09-09T02:26:13Z

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

gcf-owl-bot · 2022-09-09T14:12:50Z

Owl bot is regenerating pull request 1030...
Build name: NDU4Mzg0ZmMtNWE4ZS00Nzk5LWI4MjItYjE5MTgwMTg3MTg4

gcf-merge-on-green · 2022-09-09T22:04:21Z

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

suztomo · 2022-09-14T21:05:20Z

Integration test failed.

org.junit.runners.model.TestTimedOutException: test timed out after 1 seconds
	at sun.misc.Unsafe.park(Native Method)
	at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
	at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:557)
	at com.google.common.util.concurrent.FluentFuture$TrustedFuture.get(FluentFuture.java:91)
	at com.google.common.util.concurrent.ForwardingFuture.get(ForwardingFuture.java:66)
	at com.google.cloud.firestore.BulkWriter.close(BulkWriter.java:713)
	at com.google.cloud.firestore.BulkWriterTest.sendsBackoffBatchAfterOtherEnqueuedBatches(BulkWriterTest.java:1280)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

Retrying.

suztomo · 2022-09-14T21:06:30Z

...ud-firestore-admin/src/test/java/com/google/cloud/firestore/v1/FirestoreAdminClientTest.java

-            Arrays.<MockGrpcService>asList(mockFirestoreAdmin, mockLocations));
+            Arrays.<MockGrpcService>asList(mockFirestoreAdmin));


This class is annotated with @Generated("by gapic-generator-java"). It was failing

[INFO] ------------------------------------------------------------- Error: COMPILATION ERROR : [INFO] ------------------------------------------------------------- Error: /home/runner/work/java-firestore/java-firestore/google-cloud-firestore/src/main/java/com/google/cloud/firestore/v1/stub/HttpJsonFirestoreStub.java:[196,35] method toBody in class com.google.api.gax.httpjson.ProtoRestSerializer<RequestT> cannot be applied to given types; required: java.lang.String,com.google.protobuf.Message found: java.lang.String,com.google.firestore.v1.Document,boolean reason: actual and formal argument lists differ in length ...

https://github.com/googleapis/java-firestore/actions/runs/3055800893/jobs/4929266467

In this commit, @dconeybe manually fixed the compilation error. Because this is auto-generated code, the error would come again without fixing the root cause. I'll ask my teammates who may have clues.

Note that this PR was re-generated today 1 hour ago #1030 (comment)

The path of the FirestoreAdminClientTest.java is

google-cloud-firestore-admin/src/test/java/com/google/cloud/firestore/v1/FirestoreAdminClientTest.java

OwlBot's configuration file https://github.com/googleapis/java-firestore/blob/main/.github/.OwlBot.yaml

The change in googleapis-gen already includes the problematic code:

The the compilation error is before OwlBot.

@dconeybe Let's merge #1032 first.

gcf-owl-bot · 2022-09-14T21:43:18Z

Owl bot is regenerating pull request 1030...
Build name: ZjVlYzA1MjAtMjRmMC00YWFhLWI0NGQtNWQyYTY2MzU1YTBl

suztomo · 2022-09-14T21:43:48Z

Merged #1032 and clicked "Regenerate" checkbox. Next generation should not require manual intervention.

suztomo · 2022-09-14T22:03:08Z

Even after shared dependencies BOM 3.0.2 (#1032), it still hits compilation error at c084f42.

[INFO] -------------------------------------------------------------
Error:  COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/java-firestore/java-firestore/google-cloud-firestore-admin/src/test/java/com/google/cloud/firestore/v1/MockLocationsImpl.java:[20,47] package com.google.cloud.location.LocationsGrpc does not exist
Error:  /home/runner/work/java-firestore/java-firestore/google-cloud-firestore-admin/src/test/java/com/google/cloud/firestore/v1/MockLocationsImpl.java:[30,40] cannot find symbol
  symbol: class LocationsImplBase
Error:  /home/runner/work/java-firestore/java-firestore/google-cloud-firestore-admin/src/test/java/com/google/cloud/firestore/v1/MockLocations.java:[52,23] cannot find symbol
  symbol:   method bindService()
  location: variable serviceImpl of type com.google.cloud.firestore.v1.MockLocationsImpl
[INFO] 3 errors

gcf-owl-bot · 2022-09-15T00:25:37Z

Owl bot is regenerating pull request 1030...
Build name: N2U2ODNlZTMtMGQ5My00ZWI0LWI1MTktNzkxY2VjYmUzZGVh

suztomo · 2022-09-15T00:27:06Z

@dconeybe All checks are now green without manual Java code change.

…ranch PiperOrigin-RevId: 473753776 Source-Link: googleapis/googleapis@a8c6c7c Source-Link: https://github.com/googleapis/googleapis-gen/commit/6e3b0d6ead4265ca6f0ad3e1829f4e3a5bc109a2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmUzYjBkNmVhZDQyNjVjYTZmMGFkM2UxODI5ZjRlM2E1YmMxMDlhMiJ9 chore(bazel): Update WORKSPACE files for rules_gapic, gax_java, generator_java versions PiperOrigin-RevId: 472750037 Source-Link: googleapis/googleapis@88f2ea3 Source-Link: https://github.com/googleapis/googleapis-gen/commit/230a5588306aae18fe8f2a57f14d4039ad72c901 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

dconeybe · 2022-09-15T00:46:28Z

@dconeybe All checks are now green without manual Java code change.

@suztomo I'm seeing many failed actions, for the same reason. Can you double check?

meltsufin · 2022-09-15T01:32:35Z

@dconeybe All checks are now green without manual Java code change.

@suztomo I'm seeing many failed actions, for the same reason. Can you double check?

I had to add grpc-google-common-protos:test. @suztomo Is that expected??

suztomo · 2022-09-15T01:36:53Z

Yes. The test starts to use the class in that dependency.

suztomo · 2022-09-15T12:37:33Z

Yes, in current process, poms are not updated when a new dependency is introduced.

gcf-owl-bot bot requested a review from a team as a code owner September 7, 2022 19:44

gcf-owl-bot bot requested a review from a team September 7, 2022 19:44

gcf-owl-bot bot added the owl-bot-copy label Sep 7, 2022

product-auto-label bot added the api: firestore Issues related to the googleapis/java-firestore API. label Sep 7, 2022

trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 7, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022

trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 7, 2022

meltsufin approved these changes Sep 8, 2022

View reviewed changes

meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Sep 8, 2022

gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 9, 2022

meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Sep 9, 2022

gcf-owl-bot bot force-pushed the owl-bot-copy branch from 4509638 to 483ef31 Compare September 9, 2022 14:19

trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 9, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022

trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 9, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 9, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022

meltsufin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2022

gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 9, 2022

meltsufin approved these changes Sep 10, 2022

View reviewed changes

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2022

trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 14, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 14, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2022

suztomo reviewed Sep 14, 2022

View reviewed changes

gcf-owl-bot bot force-pushed the owl-bot-copy branch from 4b9dcc2 to c5d16ac Compare September 14, 2022 21:46

trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 14, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 14, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2022

trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 14, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 14, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 14, 2022

gcf-owl-bot bot added 2 commits September 15, 2022 00:29

🦉 Updates from OwlBot post-processor

e55d12e

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

add missing test dependencies

22fe345

dconeybe approved these changes Sep 15, 2022

View reviewed changes

release-please bot mentioned this pull request Sep 16, 2022

chore(main): release 3.5.0 #1035

Merged

		Arrays.<MockGrpcService>asList(mockFirestoreAdmin, mockLocations));
		Arrays.<MockGrpcService>asList(mockFirestoreAdmin));

Conversation

gcf-owl-bot bot commented Sep 7, 2022 • edited by meltsufin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gcf-merge-on-green bot commented Sep 9, 2022

Uh oh!

gcf-owl-bot bot commented Sep 9, 2022

Uh oh!

gcf-merge-on-green bot commented Sep 9, 2022

Uh oh!

suztomo commented Sep 14, 2022

Uh oh!

suztomo Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suztomo Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suztomo Sep 14, 2022

Choose a reason for hiding this comment

Uh oh!

gcf-owl-bot bot commented Sep 14, 2022

Uh oh!

suztomo commented Sep 14, 2022

Uh oh!

suztomo commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gcf-owl-bot bot commented Sep 15, 2022

Uh oh!

suztomo commented Sep 15, 2022

Uh oh!

dconeybe commented Sep 15, 2022

Uh oh!

meltsufin commented Sep 15, 2022

Uh oh!

suztomo commented Sep 15, 2022

Uh oh!

suztomo commented Sep 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gcf-owl-bot bot commented Sep 7, 2022 •

edited by meltsufin

Loading

suztomo Sep 14, 2022 •

edited

Loading

suztomo Sep 14, 2022 •

edited

Loading

suztomo commented Sep 14, 2022 •

edited

Loading