fix: elide string processing of 'fine' level log messages unless they will actually be logged (#2055)

dconeybe · web-flow · commit 22a41a265a24 · 2025-03-21T10:32:28.000-04:00
diff --git a/README.md b/README.md
@@ -41,7 +41,7 @@ If you are using Maven without the BOM, add this to your dependencies:
 <dependency>
   <groupId>com.google.cloud</groupId>
   <artifactId>google-cloud-firestore</artifactId>
-  <version>3.30.10</version>
+  <version>3.30.11</version>
 </dependency>
 
 ```
diff --git a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/SilenceableBidiStream.java b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/SilenceableBidiStream.java
@@ -63,7 +63,7 @@ public boolean isSilenced() {
   }
 
   public void send(RequestT request) {
-    LOGGER.fine(stream.toString());
+    LOGGER.fine(stream::toString);
     stream.send(request);
   }
 
diff --git a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Watch.java b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Watch.java
@@ -474,7 +474,7 @@ private void pushSnapshot(final Timestamp readTime, ByteString nextResumeToken)
     if (!hasPushed || !changes.isEmpty()) {
       final QuerySnapshot querySnapshot =
           QuerySnapshot.withChanges(query, readTime, documentSet, changes);
-      LOGGER.fine(querySnapshot.toString());
+      LOGGER.fine(querySnapshot::toString);
       userCallbackExecutor.execute(() -> listener.onEvent(querySnapshot, null));
       hasPushed = true;
     }

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ public boolean isSilenced() {`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`public void send(RequestT request) {`
`66`		`- LOGGER.fine(stream.toString());`
	`66`	`+ LOGGER.fine(stream::toString);`
`67`	`67`	`stream.send(request);`
`68`	`68`	`}`
`69`	`69`
Original file line number	Diff line number	Diff line change
`@@ -474,7 +474,7 @@ private void pushSnapshot(final Timestamp readTime, ByteString nextResumeToken)`
`474`	`474`	`if (!hasPushed \|\| !changes.isEmpty()) {`
`475`	`475`	`final QuerySnapshot querySnapshot =`
`476`	`476`	`QuerySnapshot.withChanges(query, readTime, documentSet, changes);`
`477`		`- LOGGER.fine(querySnapshot.toString());`
	`477`	`+ LOGGER.fine(querySnapshot::toString);`
`478`	`478`	`userCallbackExecutor.execute(() -> listener.onEvent(querySnapshot, null));`
`479`	`479`	`hasPushed = true;`
`480`	`480`	`}`