Skip to content
This repository was archived by the owner on Nov 9, 2023. It is now read-only.

chore: Removed v1beta2 samples and tests#793

Merged
galz10 merged 11 commits intogoogleapis:mainfrom
galz10:main
Apr 20, 2022
Merged

chore: Removed v1beta2 samples and tests#793
galz10 merged 11 commits intogoogleapis:mainfrom
galz10:main

Conversation

@galz10
Copy link
Copy Markdown
Contributor

@galz10 galz10 commented Mar 28, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

On February 15th, all Java batch processing samples started to fail, and more recently all v1beta2 samples are failing for similar reasons. These failures are blocking our releases and other PRs to the Document AI Java github repo.

There has been attempts by the engineering team to fix the issue with no success. Since v1beta2 is in maintenance mode we should start directing users to use the supported versions. A step in directing users to use supported versions is to remove the v1beta2 samples and tests.

@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Mar 28, 2022

Here is the summary of changes.

You are about to delete 7 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: documentai Issues related to the googleapis/java-document-ai API. samples Issues that are directly related to samples. labels Mar 28, 2022
Copy link
Copy Markdown

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please confirm this will not break any existing code samples with these region tags

@kweinmeister kweinmeister added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@product-auto-label product-auto-label Bot added the size: xl Pull request size is extra large. label Apr 13, 2022
@galz10 galz10 added the snippet-bot:force-run Force snippet-bot runs its logic label Apr 19, 2022
@snippet-bot snippet-bot Bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Apr 19, 2022
@galz10 galz10 added the snippet-bot:force-run Force snippet-bot runs its logic label Apr 20, 2022
@snippet-bot snippet-bot Bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Apr 20, 2022
@galz10
Copy link
Copy Markdown
Contributor Author

galz10 commented Apr 20, 2022

Hi @kolea2, yes this will not break any existing samples documentation that referenced these samples have been removed.

@galz10 galz10 closed this Apr 20, 2022
@galz10 galz10 reopened this Apr 20, 2022
@galz10 galz10 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 20, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 20, 2022
@galz10 galz10 merged commit d2c1ad6 into googleapis:main Apr 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: documentai Issues related to the googleapis/java-document-ai API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants