Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

chore: added extra flow for traingflow test#209

Merged
gcf-merge-on-green[bot] merged 5 commits intogoogleapis:masterfrom
munkhuushmgl:fix_overlapping_resource
May 7, 2021
Merged

chore: added extra flow for traingflow test#209
gcf-merge-on-green[bot] merged 5 commits intogoogleapis:masterfrom
munkhuushmgl:fix_overlapping_resource

Conversation

@munkhuushmgl
Copy link
Copy Markdown
Contributor

@munkhuushmgl munkhuushmgl commented May 5, 2021 •
edited
Loading

Fixes #203 ☕️

Problem is IT has only one flow that is being used in numerous tests. Because of that trainFlowTest is flaky, so it might be good idea to have seperate flow only for trainFlowTest

@munkhuushmgl munkhuushmgl requested a review from a team May 5, 2021 19:10
@product-auto-label product-auto-label Bot added the api: dialogflow Issues related to the googleapis/java-dialogflow-cx API. label May 5, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2021
stephaniewang526
stephaniewang526 suggested changes May 6, 2021
View reviewed changes
Comment thread google-cloud-dialogflow-cx/pom.xml Outdated
@ooriana ooriana added the automerge Merge the pull request once unit tests and other checks pass. label May 6, 2021
@gcf-merge-on-green
Copy link
Copy Markdown

gcf-merge-on-green Bot commented May 7, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 7, 2021
@munkhuushmgl
Copy link
Copy Markdown
Contributor Author

munkhuushmgl commented May 7, 2021 •
edited
Loading

Looks like i do not have write permission, @stephaniewang526 Could you add force-kokoro-run & automerge labels on this PR?

@jessiexjiang27 jessiexjiang27 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels May 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 7, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2021 •
edited
Loading

Codecov Report

Merging #209 (0778fba) into master (b29dfea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #209   +/-   ##
=========================================
  Coverage     76.74%   76.74%           
  Complexity     1958     1958           
=========================================
  Files           168      168           
  Lines         13668    13668           
  Branches        130      130           
=========================================
  Hits          10490    10490           
  Misses         2948     2948           
  Partials        230      230

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29dfea...0778fba. Read the comment docs.

@gcf-merge-on-green gcf-merge-on-green Bot merged commit ae769cb into googleapis:master May 7, 2021
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: dialogflow Issues related to the googleapis/java-dialogflow-cx API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dialogflow.cx.v3beta1.it.ITSystemTest: trainFlowTest failed

5 participants

@munkhuushmgl @stephaniewang526 @yoshi-kokoro @ooriana @jessiexjiang27