Skip to content
This repository was archived by the owner on Dec 3, 2023. It is now read-only.

samples: update sample code for knowledge base#898

Merged
anguillanneuf merged 4 commits intogoogleapis:mainfrom
deliaqi:sample-kb
Mar 25, 2022
Merged

samples: update sample code for knowledge base#898
anguillanneuf merged 4 commits intogoogleapis:mainfrom
deliaqi:sample-kb

Conversation

@deliaqi
Copy link
Copy Markdown
Contributor

@deliaqi deliaqi commented Mar 22, 2022

Hi, this is Jiaqi Liu. I am trying to change the sample code for KnowledgeBase to use Dialogflow V2 API, and also update the code style following samples format. Could you review it please? Thanks!

@deliaqi deliaqi requested a review from a team March 22, 2022 18:11
@product-auto-label product-auto-label Bot added api: dialogflow Issues related to the googleapis/java-dialogflow API. samples Issues that are directly related to samples. labels Mar 22, 2022
@deliaqi deliaqi requested a review from a team March 23, 2022 00:32
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .kokoro/nightly/integration.cfg

@anguillanneuf anguillanneuf added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 23, 2022
@chingor13 chingor13 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 23, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 23, 2022
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit about the license year, but otherwise LGTM

@chingor13 chingor13 requested a review from Neenu1995 March 23, 2022 22:17
@anguillanneuf anguillanneuf added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 25, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 25, 2022
@anguillanneuf anguillanneuf merged commit 5c62312 into googleapis:main Mar 25, 2022
@deliaqi deliaqi deleted the sample-kb branch March 25, 2022 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: dialogflow Issues related to the googleapis/java-dialogflow API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants