samples: add sample code for ConversationProfile, Conversation and Participant by deliaqi · Pull Request #832 · googleapis/java-dialogflow

deliaqi · 2022-01-27T20:22:56Z

Hi, this is Jiaqi Liu from CCAI - Assist and Knowledge team. We are trying to add java sample code for APIs related to CCAI-features, like answer record management and conversation management. This is the first PR for updating answer record, could you help with reviewing it? Let me know anything else needed for checking in the code. Thanks!

snippet-bot · 2022-01-27T20:22:59Z

Here is the summary of changes.

You are about to add 3 region tags.

samples/snippets/src/main/java/com/example/dialogflow/ConversationManagement.java:19, tag dialogflow_create_conversation
samples/snippets/src/main/java/com/example/dialogflow/ConversationProfileManagement.java:19, tag dialogflow_create_conversation_profile_article_suggestion
samples/snippets/src/main/java/com/example/dialogflow/ParticipantManagement.java:19, tag dialogflow_create_participant

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

chingor13

I think according to the guidelines, you should add a static main method with sample values.

deliaqi · 2022-02-15T23:00:21Z

Hi Jeff, could you review the updated code again? Let me know if you have other comments!

deliaqi · 2022-02-24T21:40:39Z

Try to add sample code that requires less long-alive resources first after discussing with @chingor13. The starting point can be sample code for ConversationProfile, Conversation and Participant.
I have updated the code and removed the previous code for AnswerRecord, could you review the PR again?

lesv

Region Tags are missing
Tests can be in a single file if that makes things easier.
Never System.setOut(null);
Please read SAMPLE_FORMAT

lesv · 2022-03-09T23:24:26Z

+        SuggestionFeatureConfig articleSuggestionFeatureConfig =
+            SuggestionFeatureConfig.newBuilder()
+                .setSuggestionFeature(
+                    SuggestionFeature.newBuilder().setType(Type.ARTICLE_SUGGESTION).build())
+                .setSuggestionTriggerSettings(
+                    SuggestionTriggerSettings.newBuilder()
+                        .setNoSmalltalk(true)
+                        .setOnlyEndUser(true)
+                        .build())
+                .setQueryConfig(
+                    SuggestionQueryConfig.newBuilder()
+                        .setKnowledgeBaseQuerySource(
+                            KnowledgeBaseQuerySource.newBuilder()
+                                .addKnowledgeBases(articleSuggestionKbName.toString()))
+                        .setMaxResults(3)
+                        .build())
+                .build();


Wow - that looks complicated. Is there an easier way to present this since we are trying to teach users here?

Functionality-wise, it's hard to simplify it as we should include such nested configurations to make the feature work, but we can improve the readability by adding variables one by one and also add more descriptions.

lesv · 2022-03-09T23:37:18Z

+    deleteConversationProfile(conversationProfileNameToDelete);
+    conversationProfileNameToDelete = null;


It looks like a failure will leave a lot of conversation Profile's around. Perhaps you'd like to make things a bit more robust.

It could be mitigated by checking conversationProfileNameToDelete during tearDown. Do you have other suggestions?

We often look for >24h old resources in the setUp() method and delete them. That way if we crash, they are eventually removed.

deliaqi · 2022-03-15T21:57:35Z

The suggestion about making one single test file is reasonable, maybe we can add an integration test file, including the workflow from creating a conversation profile to creating participants, while the current separate unit tests could still make sense for testing each component.
The regional tags should have been added, if that means comments like // [START dialogflow_create_conversation] and // [END dialogflow_create_conversation]. Could @lesv confirm it please?

lesv · 2022-03-15T23:27:32Z

@deliaqi Please internally visit github/ and join googleapis

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

deliaqi · 2022-03-16T03:45:18Z

@deliaqi Please internally visit github/ and join googleapis

Thanks, done!

lesv · 2022-03-16T16:20:04Z

Assuming owlbot runs, you should be able to merge.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

add UpdateAnswerRecord sample code

aaa4335

product-auto-label Bot added api: dialogflow Issues related to the googleapis/java-dialogflow API. samples Issues that are directly related to samples. labels Jan 27, 2022

blunderbuss-gcf Bot assigned chingor13 Jan 27, 2022

chingor13 requested a review from a team January 27, 2022 20:33

chingor13 removed their assignment Jan 27, 2022

chingor13 added the blunderbuss: assign Instruct blunderbuss to assign someone label Jan 27, 2022

blunderbuss-gcf Bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Jan 27, 2022

blunderbuss-gcf Bot assigned averikitsch Jan 27, 2022

chingor13 changed the title ~~add UpdateAnswerRecord sample code~~ samples: add UpdateAnswerRecord sample code Jan 27, 2022

chingor13 suggested changes Jan 27, 2022

View reviewed changes

averikitsch removed their assignment Jan 27, 2022

deliaqi added 2 commits January 28, 2022 09:51

update code style

1f53c4d

update code style

c181cf6

deliaqi requested a review from chingor13 January 28, 2022 22:39

deliaqi marked this pull request as draft January 29, 2022 01:10

update code style

c689147

deliaqi marked this pull request as ready for review February 1, 2022 04:38

deliaqi marked this pull request as draft February 3, 2022 23:20

add location for updating answer record

e690ea4

deliaqi marked this pull request as ready for review February 15, 2022 22:57

chingor13 suggested changes Feb 16, 2022

View reviewed changes

deliaqi added 2 commits February 16, 2022 17:24

add static main method and correct requireEnvVar method

5f688ce

add sample code for conversation, conversation profile and participant

839305d

deliaqi changed the title ~~samples: add UpdateAnswerRecord sample code~~ samples: add sample code for ConversationProfile, Conversation and Participant Feb 24, 2022

blunderbuss-gcf Bot assigned anguillanneuf Feb 24, 2022

correct requireEnvVar method and typo

447c82e

chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2022

chingor13 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2022

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2022

lesv suggested changes Mar 9, 2022

View reviewed changes

avoid returning value for snippet methods

8ed7c6d

deliaqi requested a review from lesv March 15, 2022 18:57

lesv approved these changes Mar 15, 2022

View reviewed changes

lesv added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 15, 2022

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2022

🦉 Updates from OwlBot post-processor

6c296ef

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

lesv approved these changes Mar 16, 2022

View reviewed changes

Merge branch 'main' into main

a85641a

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 16, 2022

lesv added owlbot:ignore instruct owl-bot to ignore a PR owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 16, 2022

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 16, 2022

remove code about faq assist feature

40db0b7

chingor13 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Mar 17, 2022

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2022

🦉 Updates from OwlBot post-processor

1de7346

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

chingor13 merged commit b76764a into googleapis:main Mar 17, 2022

		deleteConversationProfile(conversationProfileNameToDelete);
		conversationProfileNameToDelete = null;

Conversation

deliaqi commented Jan 27, 2022

Uh oh!

snippet-bot Bot commented Jan 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chingor13 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deliaqi commented Feb 15, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deliaqi commented Feb 24, 2022

Uh oh!

lesv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lesv Mar 9, 2022

Choose a reason for hiding this comment

Uh oh!

deliaqi Mar 15, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lesv Mar 9, 2022

Choose a reason for hiding this comment

Uh oh!

deliaqi Mar 15, 2022

Choose a reason for hiding this comment

Uh oh!

lesv Mar 15, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deliaqi commented Mar 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lesv commented Mar 15, 2022

Uh oh!

deliaqi commented Mar 16, 2022

Uh oh!

lesv commented Mar 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

snippet-bot Bot commented Jan 27, 2022 •

edited

Loading

deliaqi commented Mar 15, 2022 •

edited

Loading