Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

feat: OR query support#993

Merged
gcf-merge-on-green[bot] merged 8 commits intogoogleapis:mainfrom
kolea2:or-queries
Mar 8, 2023
Merged

feat: OR query support#993
gcf-merge-on-green[bot] merged 8 commits intogoogleapis:mainfrom
kolea2:or-queries

Conversation

@kolea2
Copy link
Copy Markdown
Contributor

@kolea2 kolea2 commented Feb 15, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: datastore Issues related to the googleapis/java-datastore API. labels Feb 15, 2023
@kolea2 kolea2 marked this pull request as ready for review March 2, 2023 16:44
@kolea2 kolea2 requested review from a team March 2, 2023 16:44
@kolea2 kolea2 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. owlbot:run Add this label to trigger the Owlbot post processor. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 2, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 7, 2023
@gcf-owl-bot gcf-owl-bot Bot requested a review from a team March 7, 2023 17:09
Copy link
Copy Markdown

@danieljbruce danieljbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jainsahab
Copy link
Copy Markdown
Contributor

just one minor comment, apart from that it's LGTM

@kolea2 kolea2 added owlbot:run Add this label to trigger the Owlbot post processor. automerge Merge the pull request once unit tests and other checks pass. labels Mar 8, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants